Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce GCP limit of 64 chars for cluster name in kubetest2 deployer #16787

Conversation

dims
Copy link
Member

@dims dims commented Aug 29, 2024

Ran into this https://storage.googleapis.com/kubernetes-jenkins/pr-logs/pull/127005/pull-kubernetes-e2e-gce-disruptive-canary/1829211781348724736/build-log.txt

I0829 17:57:21.198213   74468 new_cluster.go:1454] Cloud Provider ID: "gce"
Error: error populating configuration: error fetching network "e2e-pr127005-pull-kubernetes-e2e-gce-disruptive-canary-k8s-local": googleapi: Error 400: Invalid value for field 'network': 'e2e-pr127005-pull-kubernetes-e2e-gce-disruptive-canary-k8s-local'. Must be a match of regex '[a-z](?:[-a-z0-9]{0,61}[a-z0-9])?|[1-9][0-9]{0,19}', invalid
W0829 17:57:21.625216   15003 state.go:46] failed to run /home/prow/go/src/k8s.io/kubernetes/_rundir/d5760245-a280-4b20-9469-c66a140b00dc/kops get cluster e2e-pr127005.pull-kubernetes-e2e-gce-disruptive-canary.k8s.local -ojson; stderr=Error: cluster not found "e2e-pr127005.pull-kubernetes-e2e-gce-disruptive-canary.k8s.local"
Error: exit status 1

Signed-off-by: Davanum Srinivas <davanum@gmail.com>
@k8s-ci-robot k8s-ci-robot requested a review from hakman August 29, 2024 18:27
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 29, 2024
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 29, 2024
@dims
Copy link
Member Author

dims commented Aug 29, 2024

/assign @rifelpet @hakman

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 29, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 29, 2024
@k8s-ci-robot k8s-ci-robot merged commit b98eed0 into kubernetes:master Aug 29, 2024
24 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.31 milestone Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants