Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move more nodeup script logic to NodeUpScript #16793

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

justinsb
Copy link
Member

This enables simpler reuse.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 30, 2024
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 30, 2024
@justinsb justinsb force-pushed the refactor_nodeup_script branch from 7560ca5 to c9eb14a Compare August 30, 2024 12:51
@justinsb justinsb force-pushed the refactor_nodeup_script branch from c9eb14a to 6e036b3 Compare August 30, 2024 13:14
@justinsb
Copy link
Member Author

/retest

Looks to have picked up a prior revision of the PR

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 30, 2024
@hakman
Copy link
Member

hakman commented Aug 30, 2024

/cc @rifelpet

@k8s-ci-robot k8s-ci-robot requested a review from rifelpet August 30, 2024 14:38
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman, rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit d71c6b2 into kubernetes:master Aug 30, 2024
23 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.31 milestone Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants