Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit GCP subnet secondary alias names to 63 chars #16808

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

rifelpet
Copy link
Member

@rifelpet rifelpet commented Sep 5, 2024

This should fix these GCP jobs that have long cluster names:

https://testgrid.k8s.io/kops-gce#ci-kubernetes-e2e-cos-gce-reboot-canary

Error: error running tasks: deadline exceeded executing task Subnet/us-central1-e2e-e2e-ci-kubernetes-e2e-cos-gce-reboot-can-a1ernl. Example error: error creating Subnet: googleapi: Error 400: Invalid value for field 'resource.secondaryIpRanges[1].rangeName': 'services-e2e-e2e-ci-kubernetes-e2e-cos-gce-reboot-canary-k8s-local'. Must be a match of regex '(?:[a-z](?:[-a-z0-9]{0,61}[a-z0-9])?)', invalid

// SafeSuffixedObjectName returns the object name and cluster name escaped for GCE, limited to 63 chars
func (c *GCEModelContext) SafeSuffixedObjectName(name string) string {
return gce.ClusterSuffixedName(name, c.Cluster.ObjectMeta.Name, 63)
}

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 5, 2024
@k8s-ci-robot k8s-ci-robot requested a review from hakman September 5, 2024 02:16
@k8s-ci-robot k8s-ci-robot added the area/provider/gcp Issues or PRs related to gcp provider label Sep 5, 2024
@k8s-ci-robot k8s-ci-robot requested a review from zetaab September 5, 2024 02:16
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 5, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 5, 2024
@k8s-ci-robot k8s-ci-robot merged commit 693874a into kubernetes:master Sep 5, 2024
23 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.31 milestone Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/gcp Issues or PRs related to gcp provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants