Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws: Fix awsup default and DescribeTag max retries #16887

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

AndrewSirenko
Copy link
Contributor

WIP See #16886

Rewire the non-default AWS SDK RetryMaxAttempts constants that may have been lost in the AWS SDK v1 to v2 migration.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 9, 2024
@k8s-ci-robot k8s-ci-robot requested review from hakman and zetaab October 9, 2024 17:48
@k8s-ci-robot k8s-ci-robot added the area/provider/aws Issues or PRs related to aws provider label Oct 9, 2024
@hakman
Copy link
Member

hakman commented Oct 10, 2024

/cc @rifelpet
/assign @rifelpet

Copy link
Member

@rifelpet rifelpet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. Feel free to remove WIP from the PR title and it will merge.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 11, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 11, 2024
@hakman hakman changed the title WIP awsup match kops v1.29.x AWS SDK max retries aws: Fix awsup default and DescribeTag max retries Oct 11, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 11, 2024
@k8s-ci-robot k8s-ci-robot merged commit c2cd74a into kubernetes:master Oct 11, 2024
23 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.31 milestone Oct 11, 2024
k8s-ci-robot added a commit that referenced this pull request Oct 11, 2024
…-upstream-release-1.30

Automated cherry pick of #16887: Fix awsup default and DescribeTag max retries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/aws Issues or PRs related to aws provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants