-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cilium): adding EnableLocalRedirectPolicy parameter #16929
Conversation
Hi @ana-aguilar7. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
if c.EnableLocalRedirectPolicy == nil { | ||
c.EnableLocalRedirectPolicy = fi.PtrTo(false) | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove these changes. Defaults are needed only when set to true
. The generated output should not change.
/retest |
/test pull-kops-e2e-cni-cilium |
/retest |
Thanks @ana-aguilar7! 🥳 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/override pull-kops-e2e-cni-cilium-eni |
@hakman: Overrode contexts on behalf of hakman: pull-kops-e2e-cni-cilium-eni In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Context
This PR adds the EnableLocalRedirectPolicy parameter to the Cilium spec in kOps, allowing optional activation of the Local Redirect Policy.