Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix channels for K8s 1.26 #16958

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Conversation

hakman
Copy link
Member

@hakman hakman commented Nov 26, 2024

Closes #16956.

/cc @rifelpet @justinsb

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/channels size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 26, 2024
@hakman
Copy link
Member Author

hakman commented Nov 26, 2024

/cc @moshevayner

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 26, 2024
@moshevayner
Copy link
Member

😱
Sorry about that!
/lgtm

@hakman
Copy link
Member Author

hakman commented Nov 26, 2024

😱 Sorry about that! /lgtm

No worries @moshevayner. Thanks for taking the time to update the channels.
Thank you also @jValdron

@hakman
Copy link
Member Author

hakman commented Nov 26, 2024

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 26, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman, moshevayner, rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit ec4bd07 into kubernetes:master Nov 26, 2024
23 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.31 milestone Nov 26, 2024
@hakman hakman deleted the fix-channels-1.26.16 branch November 27, 2024 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/channels cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Latest stable channel update references breaks 1.26 clusters
4 participants