-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixup kubelet and controlPlaneKubelet config building #16975
Conversation
We need to differentiate between the version of the control plane and the version of the nodes.
/retest |
/test all |
/retest |
/retest Both on cilium, so could be real, but worth a retest |
eni always fails on those 2 tests |
/override pull-kops-e2e-cni-cilium-eni |
@hakman: Overrode contexts on behalf of hakman: pull-kops-e2e-cni-cilium-eni In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/override pull-kops-e2e-cni-cilium-etcd |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@hakman: Overrode contexts on behalf of hakman: pull-kops-e2e-cni-cilium-etcd In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
We need to differentiate between the version of the control plane
and the version of the nodes.