Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup kubelet and controlPlaneKubelet config building #16975

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

justinsb
Copy link
Member

@justinsb justinsb commented Dec 4, 2024

We need to differentiate between the version of the control plane
and the version of the nodes.

We need to differentiate between the version of the control plane
and the version of the nodes.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 4, 2024
@hakman
Copy link
Member

hakman commented Dec 4, 2024

/retest

@hakman
Copy link
Member

hakman commented Dec 4, 2024

/test all

@hakman
Copy link
Member

hakman commented Dec 4, 2024

/retest

@justinsb
Copy link
Member Author

justinsb commented Dec 4, 2024

/retest

Both on cilium, so could be real, but worth a retest

@hakman
Copy link
Member

hakman commented Dec 4, 2024

/retest

Both on cilium, so could be real, but worth a retest

eni always fails on those 2 tests

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 4, 2024
@hakman
Copy link
Member

hakman commented Dec 4, 2024

/override pull-kops-e2e-cni-cilium-eni

@k8s-ci-robot
Copy link
Contributor

@hakman: Overrode contexts on behalf of hakman: pull-kops-e2e-cni-cilium-eni

In response to this:

/override pull-kops-e2e-cni-cilium-eni

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@hakman
Copy link
Member

hakman commented Dec 4, 2024

/override pull-kops-e2e-cni-cilium-etcd

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 4, 2024
@k8s-ci-robot
Copy link
Contributor

@hakman: Overrode contexts on behalf of hakman: pull-kops-e2e-cni-cilium-etcd

In response to this:

/override pull-kops-e2e-cni-cilium-etcd

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot merged commit 3a8a13f into kubernetes:master Dec 4, 2024
27 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.31 milestone Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/api area/nodeup cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants