Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.31.0-beta.1 #17138

Merged
merged 1 commit into from
Dec 15, 2024
Merged

Conversation

justinsb
Copy link
Member

Release 1.31.0-beta.1

@justinsb justinsb added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Dec 14, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 14, 2024
@justinsb
Copy link
Member Author

/test pull-kops-e2e-k8s-gce-cilium

@hakman
Copy link
Member

hakman commented Dec 14, 2024

[It] [sig-network] Services should implement NodePort and HealthCheckNodePort correctly when ExternalTrafficPolicy changes

This test always fails for pull-kops-e2e-k8s-gce-cilium.
/override pull-kops-e2e-k8s-gce-cilium

@k8s-ci-robot
Copy link
Contributor

@hakman: Overrode contexts on behalf of hakman: pull-kops-e2e-k8s-gce-cilium

In response to this:

[It] [sig-network] Services should implement NodePort and HealthCheckNodePort correctly when ExternalTrafficPolicy changes
This test always fails for pull-kops-e2e-k8s-gce-cilium.
/override pull-kops-e2e-k8s-gce-cilium

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 14, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 14, 2024
@justinsb
Copy link
Member Author

Thanks for the cilium pointer - and I am looking at the bare metal test!

@k8s-triage-robot
Copy link

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

2 similar comments
@k8s-triage-robot
Copy link

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

@k8s-triage-robot
Copy link

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

@hakman
Copy link
Member

hakman commented Dec 15, 2024

/override tests-e2e-scenarios-bare-metal

@kubernetes kubernetes deleted a comment from k8s-ci-robot Dec 15, 2024
@k8s-triage-robot
Copy link

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

2 similar comments
@k8s-triage-robot
Copy link

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

@k8s-triage-robot
Copy link

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

@hakman
Copy link
Member

hakman commented Dec 15, 2024

Thanks for the cilium pointer - and I am looking at the bare metal test!

@justinsb I think we had the same issue at previous release, right @rifelpet?
We just manually merged the PR at that time.

@justinsb
Copy link
Member Author

Thanks for the cilium pointer - and I am looking at the bare metal test!

@justinsb I think we had the same issue at previous release, right @rifelpet? We just manually merged the PR at that time.

Ah, I think that's the right thing to do.

First of all, this test is experimental functionality anyway, so shouldn't block a release.

In this case, the issue is that kops-controller is not getting KOPS_BASE_URL, I think, because this is the error from those logs:

I1214 19:42:14.016404       1 builder.go:317] asset "https://artifacts.k8s.io/binaries/kops/1.31.0-beta.1/linux/amd64/nodeup" is not well-known, downloading hash
I1214 19:42:14.055707       1 context.go:317] hit maximum retries 1 with error file does not exist
I1214 19:42:14.055743       1 builder.go:337] Unable to read hash file "https://artifacts.k8s.io/binaries/kops/1.31.0-beta.1/linux/amd64/nodeup.sha256": file does not exist
I1214 19:42:14.199812       1 context.go:317] hit maximum retries 1 with error file does not exist
I1214 19:42:14.199846       1 builder.go:337] Unable to read hash file "https://github.com/kubernetes/kops/releases/download/v1.31.0-beta.1/nodeup-linux-amd64.sha256": file does not exist
I1214 19:42:14.199855       1 builder.go:352] Unable to read new sha256 hash file (is this an older/unsupported kubernetes release?)
I1214 19:42:14.236349       1 context.go:317] hit maximum retries 1 with error file does not exist

So yes, agree with manual merge!

@hakman hakman merged commit e13ed61 into kubernetes:master Dec 15, 2024
22 of 24 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.31 milestone Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants