Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update flannel to v0.26.4 #17179

Merged
merged 3 commits into from
Feb 8, 2025
Merged

Update flannel to v0.26.4 #17179

merged 3 commits into from
Feb 8, 2025

Conversation

hakman
Copy link
Member

@hakman hakman commented Jan 7, 2025

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 7, 2025
@k8s-ci-robot k8s-ci-robot added area/addons size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 7, 2025
@hakman
Copy link
Member Author

hakman commented Jan 7, 2025

/retest

2 similar comments
@hakman
Copy link
Member Author

hakman commented Jan 7, 2025

/retest

@hakman
Copy link
Member Author

hakman commented Jan 7, 2025

/retest

@hakman
Copy link
Member Author

hakman commented Jan 7, 2025

/test pull-kops-e2e-cni-flannel

@ameukam
Copy link
Member

ameukam commented Jan 7, 2025

/retest

@hakman
Copy link
Member Author

hakman commented Jan 7, 2025

/test pull-kops-e2e-cni-flannel

@hakman hakman changed the title Update flannel to v0.26.2 WIP Update flannel to v0.26.2 Jan 8, 2025
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 8, 2025
@hakman hakman changed the title WIP Update flannel to v0.26.2 Update flannel to v0.26.2 Jan 8, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 8, 2025
@hakman hakman marked this pull request as draft January 8, 2025 11:05
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 8, 2025
@hakman
Copy link
Member Author

hakman commented Feb 8, 2025

Adding some more pre-submits in kubernetes/test-infra#34300.

@hakman
Copy link
Member Author

hakman commented Feb 8, 2025

/test pull-kops-e2e-cni-flannel-u2004
/test pull-kops-e2e-cni-flannel-u2204

@hakman
Copy link
Member Author

hakman commented Feb 8, 2025

/test pull-kops-e2e-cni-flannel-u2004

@hakman
Copy link
Member Author

hakman commented Feb 8, 2025

/test pull-kops-e2e-cni-flannel-u2204

@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/api and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 8, 2025
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 8, 2025
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 8, 2025
@hakman hakman marked this pull request as ready for review February 8, 2025 17:51
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 8, 2025
@k8s-ci-robot k8s-ci-robot requested a review from zetaab February 8, 2025 17:51
@hakman hakman requested review from rifelpet and removed request for olemarkus, johngmyers and zetaab February 8, 2025 17:52
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Feb 8, 2025 •
edited
Loading

@hakman: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kops-e2e-gce-cni-calico 770edd0 link true /test pull-kops-e2e-gce-cni-calico
pull-kops-e2e-gce-cni-kindnet 770edd0 link true /test pull-kops-e2e-gce-cni-kindnet
pull-kops-e2e-k8s-aws-amazonvpc-u2404 770edd0 link true /test pull-kops-e2e-k8s-aws-amazonvpc-u2404

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@hakman
Copy link
Member Author

hakman commented Feb 8, 2025

/override pull-kops-kubernetes-e2e-ubuntu-gce-build

@k8s-ci-robot
Copy link
Contributor

@hakman: Overrode contexts on behalf of hakman: pull-kops-kubernetes-e2e-ubuntu-gce-build

In response to this:

/override pull-kops-kubernetes-e2e-ubuntu-gce-build

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@rifelpet
Copy link
Member

rifelpet commented Feb 8, 2025

should we update these docs?

kops/docs/networking/flannel.md

Line 3 in 62621fa

⚠ The Flannel CNI is not supported for Kubernetes 1.28 or later.

@hakman
Copy link
Member Author

hakman commented Feb 8, 2025

should we update these docs?

kops/docs/networking/flannel.md

Line 3 in 62621fa

⚠ The Flannel CNI is not supported for Kubernetes 1.28 or later.

@rifelpet Just wanted to let this run in testgrid for a few days first.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 8, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 8, 2025
@k8s-ci-robot k8s-ci-robot merged commit e77300b into kubernetes:master Feb 8, 2025
29 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.32 milestone Feb 8, 2025
@hakman hakman deleted the flannel-0.26.2 branch February 8, 2025 20:18
This was referenced Feb 9, 2025
Merged
Closed
Merged
Merged
k8s-ci-robot added a commit that referenced this pull request Feb 9, 2025
@k8s-ci-robot
Merge pull request #17255 from hakman/automated-cherry-pick-of-#17179…
fc6aa90 
…-upstream-release-1.32

Automated cherry pick of #17179: Re-enable Flannel
k8s-ci-robot added a commit that referenced this pull request Feb 9, 2025
@k8s-ci-robot
Merge pull request #17258 from hakman/automated-cherry-pick-of-#17179…
4b65cf9 
…-upstream-release-1.31

Automated cherry pick of #17179: Re-enable Flannel
k8s-ci-robot added a commit that referenced this pull request Feb 9, 2025
@k8s-ci-robot
Merge pull request #17257 from hakman/automated-cherry-pick-of-#17179…
d8e2b33 
…-upstream-release-1.30

Automated cherry pick of #17179: Re-enable Flannel
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rifelpet rifelpet rifelpet approved these changes

Assignees

@rifelpet rifelpet

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/addons area/api area/nodeup cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.32
Development

Successfully merging this pull request may close these issues.
4 participants
@hakman @ameukam @k8s-ci-robot @rifelpet