Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change to EtcdBuilder in ETCD model #2813

Merged
merged 1 commit into from
Jun 25, 2017
Merged

Change to EtcdBuilder in ETCD model #2813

merged 1 commit into from
Jun 25, 2017

Conversation

shamil
Copy link
Contributor

@shamil shamil commented Jun 24, 2017 •
edited by k8s-reviewable
Loading

Not sure why this line exists and if it's needed at all, @justinb, @chrislovecnm?
In any case, this should be EtcdBuilder and not LogrotateBuilder

This change is Reviewable

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 24, 2017
@k8s-ci-robot
Copy link
Contributor

Hi @shamil. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 24, 2017
@chrislovecnm
Copy link
Contributor

@k8s-bot ok to test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 24, 2017
@chrislovecnm chrislovecnm self-assigned this Jun 24, 2017
chrislovecnm
chrislovecnm reviewed Jun 24, 2017
View reviewed changes
Copy link
Contributor

@chrislovecnm chrislovecnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks good catch!

@chrislovecnm
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 24, 2017
@chrislovecnm
Copy link
Contributor

Waiting on e2e

chrislovecnm
chrislovecnm approved these changes Jun 25, 2017
View reviewed changes
Copy link
Contributor

@chrislovecnm chrislovecnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@chrislovecnm chrislovecnm merged commit b32ee5a into kubernetes:master Jun 25, 2017
@shamil shamil deleted the patch-3 branch June 25, 2017 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrislovecnm chrislovecnm chrislovecnm approved these changes

Assignees

@chrislovecnm chrislovecnm

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shamil @k8s-ci-robot @chrislovecnm