Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile targets for go 1.8 & 1.9 #2848

Merged
merged 1 commit into from
Jul 4, 2017

Conversation

justinsb
Copy link
Member

@justinsb justinsb commented Jul 1, 2017

check-build Makefile targets for 1.8 & 1.9

Also runs the full ci target now


This change is Reviewable

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 1, 2017
@justinsb
Copy link
Member Author

justinsb commented Jul 1, 2017

This is no longer a blocker as I merged @chrislovecnm 's earlier PR instead.

@justinsb justinsb changed the title Stop testing with golang 1.7 Makefile targets for 1.7 / 1.8 Jul 1, 2017
Also runs the full ci target now
@justinsb justinsb changed the title Makefile targets for 1.7 / 1.8 Makefile targets for go 1.8 & 1.9 Jul 1, 2017
@geojaz geojaz self-assigned this Jul 4, 2017
Copy link
Member

@geojaz geojaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 4, 2017
@chrislovecnm
Copy link
Contributor

Merging on @geojaz lgtm

@chrislovecnm chrislovecnm merged commit db8c75b into kubernetes:master Jul 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants