Add a feature flag for formatting assets #2968
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
docs/releases/1.7-NOTES.md
Outdated
|
|
||
| * Manifests are rewritten by default, which includes a normalization phase. | ||
| This can make it hard to understand the actual changes (as opposed to just the formatting changes). | ||
| A feature flag has been added, `export KOPS_FEATURE_FLAGS="-RewriteManifests"` which can be used |
There was a problem hiding this comment.
Not sure what the purpose of this it actually is. To the uninitiated it looks like you are running an update on a cluster twice. Can we add more context or pull?
There was a problem hiding this comment.
You should try kops update on an existing cluster, with master
There was a problem hiding this comment.
I have and that is what you need to mention ;) Because of change x we did, when running on an existing cluster, you will get y behavior.
justinsb
force-pushed
the
make_manifest_rewrite_optional
branch
2 times, most recently
from
7298ebc to
1cd8b49
Compare
|
Now with enhanced release notes |
|
Your merge with builder.go did not go ok - pkg/assets/builder.go:22: imported and not used: "k8s.io/kops/vendor/github.com/golang/glog" |
|
Can I have "LGTM subject to passing tests" please? Don't want to lose another day.... |
Image rewriting involves a yaml format of the manifests, which makes for a large and hard to read diff. Add a feature flag to disable it, along with a workaround to the release notes.
justinsb
force-pushed
the
make_manifest_rewrite_optional
branch
from
1cd8b49 to
8b717cf
Compare
|
/assign |
k8s-ci-robot
added
the
lgtm
|
Self merge if you are impatient ;) |
Image rewriting involves a yaml format of the manifests, which makes for
a large and hard to read diff. Add a feature flag to disable it, along
with a workaround to the release notes.