Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Weave Net to version 2.1.3 #3944

Merged
merged 2 commits into from
Dec 14, 2017
Merged

Update Weave Net to version 2.1.3 #3944

merged 2 commits into from
Dec 14, 2017

Conversation

bboreham
Copy link
Contributor

This version supports 'v1' NetworkPolicy semantics.

Also includes a feature to clear down data for deleted nodes, which is probably the most-requested fix.

@bboreham
Update Weave Net to version 2.1.2
f1c8d89 
This version supports 'v1' NetworkPolicy semantics.
Also includes a feature to clear down data for deleted nodes.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 28, 2017
@chrislovecnm
Copy link
Contributor

You want this in kops 1.8? How have you tested this with kops?

I would love to get this in, but I do not want to break stuff as well ;)

@justinsb justinsb added this to the 1.8.0 milestone Nov 30, 2017
@chrislovecnm
Copy link
Contributor

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 30, 2017
@chrislovecnm chrislovecnm modified the milestones: 1.8.0, 1.9 Dec 1, 2017
@bboreham bboreham changed the title Update Weave Net to version 2.1.2 Update Weave Net to version 2.1.3 Dec 4, 2017
@bboreham
Copy link
Contributor Author

bboreham commented Dec 4, 2017

Tested by creating a kops cluster, changing the ASG to 10 nodes, down to 5, up to 10, and so on.
Inspecting weave container logs and running the nettest container used in Weave Net CI.
In the process I found a race condition in 2.1.2, which is fixed in 2.1.3.

@bboreham
Copy link
Contributor Author

Any thoughts on getting this merged?

@justinsb
Copy link
Member

/lgtm

We also need to bump the version in bootstrapchannelbuilder, but I'll just send a PR for that

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 14, 2017
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 14, 2017
@justinsb
Copy link
Member

Sent #4062

@justinsb justinsb mentioned this pull request Dec 14, 2017
Merged
@chrislovecnm
Copy link
Contributor

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 14, 2017
@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue.

@k8s-github-robot k8s-github-robot merged commit 291edf3 into kubernetes:master Dec 14, 2017
@gambol99 gambol99 mentioned this pull request Dec 14, 2017
Closed
@erickt erickt mentioned this pull request Dec 29, 2017
Closed
@jjo jjo mentioned this pull request Jan 27, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@justinsb justinsb

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.
5 participants
@bboreham @chrislovecnm @justinsb @k8s-ci-robot @k8s-github-robot