-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing permissions for NLB creation #3976
Add missing permissions for NLB creation #3976
Conversation
/hold CI is not happy. Should we only add these perms for k8s 1.9 and above? |
182938d
to
9eb0dd4
Compare
9a22c19
to
ac20b67
Compare
ac20b67
to
683799c
Compare
@chrislovecnm the failure was related to the tests, not k8s. |
/hold cancel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
thanks
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: geojaz The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
/test all [submit-queue is verifying that this PR is safe to merge] |
Automatic merge from submit-queue. |
Without this permissions is not possible to create a network load balancer (alpha in k8s >= 1.9)