nodeup: create kubeconfig under admin or root #4077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
While the admin account is created on stock debian images, it isn't on all of them. Check admin first, then check root, and don't treat it as an error if neither is found - this is only a convenience.
nodeup/pkg/model/kubectl.go
Outdated
| return err | ||
| } | ||
|
|
||
| if adminUser != "" { | ||
| c.AddTask(&nodetasks.File{ | ||
| Path: "/home/admin/.kube/", |
There was a problem hiding this comment.
Should the path differ here based on the value of adminUser?
nodeup/pkg/model/kubectl.go
Outdated
| Owner: s("admin"), | ||
| Group: s("admin"), | ||
| Owner: s(adminUser), | ||
| Group: s(adminGroup), | ||
| }) | ||
|
|
||
| c.AddTask(&nodetasks.File{ | ||
| Path: "/home/admin/.kube/config", |
justinsb
force-pushed
the
admin_or_root
branch
from
51fd5d5 to
743e482
Compare
|
You're absolutely right @KashifSaadat - thank you! |
|
Thanks! :) /lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: KashifSaadat The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
k8s-ci-robot
added
the
approved
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the admin account is created on stock debian images, it isn't on
all of them. Check admin first, then check root, and don't treat it as
an error if neither is found - this is only a convenience.