Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds permissions for ELB and NLB req'd by 1.9 #4095

Merged
merged 1 commit into from
Dec 17, 2017
Merged

Adds permissions for ELB and NLB req'd by 1.9 #4095

merged 1 commit into from
Dec 17, 2017

Conversation

geojaz
Copy link
Member

@geojaz geojaz commented Dec 17, 2017

Adds appropriate IAM permissions to Masters (in restrictive mode) for ELB and NLB.

Closes #3883

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 17, 2017
@aledbf
Copy link
Member

aledbf commented Dec 17, 2017

@geojaz please addd the missing permissions

{
    "Sid": "kopsK8sNLBMasterPermsRestrictive",
    "Effect": "Allow",
    "Action": [
        "elasticloadbalancing:CreateListener",
        "elasticloadbalancing:DeleteListener",
        "elasticloadbalancing:ModifyListener",
        "elasticloadbalancing:DescribeListeners",
        "elasticloadbalancing:CreateTargetGroup",
        "elasticloadbalancing:DeleteTargetGroup",
        "elasticloadbalancing:ModifyTargetGroup",
        "elasticloadbalancing:DescribeTargetGroups",
        "elasticloadbalancing:RegisterTargets",
        "elasticloadbalancing:DescribeTargetHealth",
        "elasticloadbalancing:AddTags",
        "ec2:DescribeVpcs"
    ],
    "Resource": [
        "*"
    ]
}

@geojaz
Copy link
Member Author

geojaz commented Dec 17, 2017

I mostly just rearranged the NLB permissions so they would be in alphabetical order, but it looks like you have some additional permissions that we didn't have previously.

I can add the missing pieces- is there some place that I can see the complete list that an ELB or NLB needs?

@aledbf
Copy link
Member

aledbf commented Dec 17, 2017

I can add the missing pieces- is there some place that I can see the complete list that an ELB or NLB needs?

No. The new permission are related to update and delete operations (testing the NLB integration)
In this PDF you can get more information http://docs.aws.amazon.com/elasticloadbalancing/latest/network/elb-ng.pdf but I didn't found a table with the required permissions

@geojaz
Copy link
Member Author

geojaz commented Dec 17, 2017

Perms updated as per @aledbf

@chrislovecnm
Copy link
Contributor

/assign @aledbf

@aledbf
Copy link
Member

aledbf commented Dec 17, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 17, 2017
@chrislovecnm
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, chrislovecnm

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 17, 2017
@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue.

@k8s-github-robot k8s-github-robot merged commit 0bfb273 into kubernetes:master Dec 17, 2017
@geojaz
Copy link
Member Author

geojaz commented Dec 17, 2017

thanks @chrislovecnm and @aledbf :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants