Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kops Replace Force #4275

Merged
merged 1 commit into from
Jan 15, 2018
Merged

Kops Replace Force #4275

merged 1 commit into from
Jan 15, 2018

Conversation

gambol99
Copy link
Contributor

This PR fixes the kops replace --force flag which was introduce in #PR3099. The --force stopped working when 65aea59 was merged and the api started returning an actual error for NotFound

@gambol99
Kops Replace Force
4cb8318 
This PR fixes the `kops replace --force` flag which was introduce in [#PR3099](kubernetes#3089). The `--force` stopped working when 65aea59 was merged and the api started returning an actual error for NotFound
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 15, 2018
@gambol99
Copy link
Contributor Author

gambol99 commented Jan 15, 2018 •
edited
Loading

@KashifSaadat if you could :-)

@gambol99
Copy link
Contributor Author

/assign @chrislovecnm

@KashifSaadat
Copy link
Contributor

Thanks, looks good!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 15, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: KashifSaadat

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 15, 2018
@k8s-ci-robot k8s-ci-robot merged commit 59440bb into kubernetes:master Jan 15, 2018
@gambol99 gambol99 deleted the fix_force_replace branch January 15, 2018 15:52
@gambol99 gambol99 mentioned this pull request Jan 20, 2018
Closed
@rifelpet rifelpet mentioned this pull request Dec 12, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@chrislovecnm chrislovecnm

@KashifSaadat KashifSaadat

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gambol99 @KashifSaadat @k8s-ci-robot @chrislovecnm