Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate IG MaxSize is not less than MinSize. #4278

Merged
merged 1 commit into from
Jan 19, 2018
Merged

Validate IG MaxSize is not less than MinSize. #4278

merged 1 commit into from
Jan 19, 2018

Conversation

mikesplain
Copy link
Contributor

Fixes #4276

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 16, 2018
@robinpercy
Copy link
Contributor

/lgtm :)

@mikesplain
Copy link
Contributor Author

@robinpercy Thanks! Although looks like it didn't give you credit :(

/assign @robinpercy

@robinpercy
Copy link
Contributor

Let's try this again

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 16, 2018
@chrislovecnm
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrislovecnm, mikesplain, robinpercy

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 17, 2018
@mikesplain
Copy link
Contributor Author

/retest

3 similar comments
@mikesplain
Copy link
Contributor Author

/retest

@mikesplain
Copy link
Contributor Author

/retest

@KashifSaadat
Copy link
Contributor

/retest

@k8s-ci-robot k8s-ci-robot merged commit b2c1e2a into kubernetes:master Jan 19, 2018
@mikesplain
Copy link
Contributor Author

Awesome, thanks @KashifSaadat

@KashifSaadat
Copy link
Contributor

No worries! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@robinpercy robinpercy

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mikesplain @robinpercy @chrislovecnm @k8s-ci-robot @KashifSaadat