add support for changing the weave peer connection limit #4398
Conversation
k8s-ci-robot
added
cncf-cla: yes
chris-h-phillips
force-pushed
the
weave-conn-limit
branch
2 times, most recently
from
7c12ea8 to
fade1fe
Compare
chris-h-phillips
force-pushed
the
weave-conn-limit
branch
from
fade1fe to
aa835ee
Compare
| // 2.1.3-kops.1 = 2.1.3, kops packaging version 1. | ||
| version := "2.1.3-kops.1" | ||
| // 2.1.3-kops.2 = 2.1.3, kops packaging version 2. | ||
| version := "2.1.3-kops.2" |
There was a problem hiding this comment.
@chrislovecnm I believe this is the version you mentioned?
There was a problem hiding this comment.
Sorry if I missed the update ...
Weave limits the number of connections between peers and the default is 30. As described here: https://github.com/weaveworks/weave/blob/ce9c5162bd94018ad5caca2c914cb5780727147c/site/kubernetes/kube-addon.md Setting the CONN_LIMIT environment variable controls this setting. Adding a field in the WeaveNetworkingSpec and adding the env var to the associated templates lets users have clusters larger than 30 nodes and still use weave's peer discovery The weave authors have indicated that 100 is not an unreasonable setting. weaveworks/weave#1621 (comment)
chris-h-phillips
force-pushed
the
weave-conn-limit
branch
from
aa835ee to
99830c4
Compare
|
/ok-to-test |
k8s-ci-robot
removed
the
needs-ok-to-test
|
/approve |
k8s-ci-robot
added
the
approved
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrislovecnm, polarbizzle The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these OWNERS Files:
Approvers can indicate their approval by writing |
|
Wow, we just hit this issue this afternoon trying to scale up nodes. Haven't tried it yet, but this connection limit variable seems to explain the exact problem we had. I wish this were far more prominent in the weave docs, so thanks @polarbizzle for the PR leading us the right direction. |
|
Ah @polarbizzle you beat me to this! We had a bit of a scare when our 31st and 32nd nodes became peers of each other instead of the rest of the cluster. Also note that weave have bumped their default connection limit to 100. |
Weave limits the number of connections between peers and the default is 30.
As described here: https://github.com/weaveworks/weave/blob/ce9c5162bd94018ad5caca2c914cb5780727147c/site/kubernetes/kube-addon.md
Setting the CONN_LIMIT environment variable controls this setting. Adding a field in the
WeaveNetworkingSpec and adding the env var to the associated templates lets users
have clusters larger than 30 nodes and still use weave's peer discovery
The weave authors have indicated that 100 is not an unreasonable setting.
weaveworks/weave#1621 (comment)