Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update status.go #4676

Merged
merged 1 commit into from
Mar 14, 2018
Merged

Update status.go #4676

merged 1 commit into from
Mar 14, 2018

Conversation

AdamDang
Copy link
Contributor

line 36: "EtcdStatus" should be replaced with "EtcdClusterStatus"
line 52: "ApiIngress" should be replaced with "ApiIngressStatus"
"EtcdStatus" and "ApiIngress" are not defined in this file.

line 36: "EtcdStatus" should be replaced with "EtcdClusterStatus"
line 52: "ApiIngress" should be replaced with "ApiIngressStatus"
"EtcdStatus" and "ApiIngress" are not defined in this file.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 14, 2018
@AdamDang
Copy link
Contributor Author

/assign @gambol99

@gambol99
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 14, 2018
@gambol99
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 14, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AdamDang, gambol99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 14, 2018
@k8s-ci-robot k8s-ci-robot merged commit 8729839 into kubernetes:master Mar 14, 2018
@AdamDang AdamDang deleted the patch-24 branch May 13, 2018 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants