Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't tag shared VPCs #4710

Merged
merged 1 commit into from
Mar 19, 2018
Merged

Don't tag shared VPCs #4710

merged 1 commit into from
Mar 19, 2018

Conversation

justinsb
Copy link
Member

Fix #4265

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 18, 2018
@justinsb justinsb force-pushed the dont_tag_shared_vpcs branch from 3e890a8 to 7f855b2 Compare March 18, 2018 21:21
@mikesplain
Copy link
Contributor

/assign
/retest

@mikesplain
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 19, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb, mikesplain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit c42ed7a into kubernetes:master Mar 19, 2018
@Nuru Nuru mentioned this pull request Apr 12, 2019
Closed
@Nuru
Copy link

Nuru commented Apr 14, 2019

The problem with this is that now there is no good way for Terraform to find what VPC a kops cluster is using. I object to this being the default, and I also think it is too specific.

I propose this be replaced with an option to disable all tagging of shared resources where tagging is not required for proper Kubernetes operation. This would definitely address #4265 without negatively impacting everyone else the way this PR does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@chrislovecnm chrislovecnm

@mikesplain mikesplain

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. blocks-next cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

kubernetes.io/cluster/<name>=shared tag being added to VPC that isn't managed by kops
5 participants
@justinsb @mikesplain @k8s-ci-robot @Nuru @chrislovecnm