Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AfterFiles dependencies to File tasks #4760

Merged

Conversation

louismunro
Copy link
Contributor

This adds a new "AfterFiles" field to the File task.
It allows File tasks to depend on the creation of another file first.
The typical use case would be for a service which depends on multiple files and must not be restarted before they are all written to disk, such as Docker.

Fixes #4747

(I am sure this can be improved. I am putting it out there as a WIP and a basis for discussion of #4747).
Feel free to squash the commits.

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 22, 2018
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 23, 2018
@robinpercy
Copy link
Contributor

Thanks @louismunro! Please sign the CLA when you get a minute.

/assign

@justinsb
Copy link
Member

This is really great - looks totally perfect and ready to go (but squashing the commits would be good) - apart from the CLA :-( Are you able to sign the CLA - it is a bit of a pain, but then it is the same CLA across all the k8s projects.

@justinsb
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 26, 2018
@louismunro
Copy link
Contributor Author

I just signed the CLA.

@robinpercy
Copy link
Contributor

/retest

@louismunro
Copy link
Contributor Author

I think the only thing that's holding it now is that I have a commit authored with another email address than the one associated with my github account. Is that a problem?
I can squash the commits myself or let whoever merges do it. Just let me know.

@louismunro louismunro force-pushed the add_AfterFiles_dependencies branch from 43d1b12 to 487dc33 Compare March 26, 2018 18:31
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Mar 26, 2018
@louismunro
Copy link
Contributor Author

I squashed all my commits. I believe that should take care of the CLA issue.

@KashifSaadat
Copy link
Contributor

@louismunro perfect, thanks for the fix and for signing the CLA. :)

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 30, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: KashifSaadat, louismunro

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 30, 2018
@k8s-ci-robot k8s-ci-robot merged commit cebc701 into kubernetes:master Mar 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants