-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AfterFiles dependencies to File tasks #4760
Add AfterFiles dependencies to File tasks #4760
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Thanks @louismunro! Please sign the CLA when you get a minute. /assign |
This is really great - looks totally perfect and ready to go (but squashing the commits would be good) - apart from the CLA :-( Are you able to sign the CLA - it is a bit of a pain, but then it is the same CLA across all the k8s projects. |
/ok-to-test |
I just signed the CLA. |
/retest |
I think the only thing that's holding it now is that I have a commit authored with another email address than the one associated with my github account. Is that a problem? |
43d1b12
to
487dc33
Compare
I squashed all my commits. I believe that should take care of the CLA issue. |
@louismunro perfect, thanks for the fix and for signing the CLA. :) /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: KashifSaadat, louismunro The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This adds a new "AfterFiles" field to the File task.
It allows File tasks to depend on the creation of another file first.
The typical use case would be for a service which depends on multiple files and must not be restarted before they are all written to disk, such as Docker.
Fixes #4747
(I am sure this can be improved. I am putting it out there as a WIP and a basis for discussion of #4747).
Feel free to squash the commits.