Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Mike and myself as reviewers #4874

Merged
merged 1 commit into from
Apr 3, 2018

Conversation

robinpercy
Copy link
Contributor

@robinpercy robinpercy commented Apr 2, 2018

Over the past three months, @mikesplain and I have worked with @chrislovecnm as part of the first reviewer cohort in the K8s mentorship program. We have both now met the Reviewer requirements outlined in https://github.com/kubernetes/community/blob/master/community-membership.md#community-membership , namely:

  • member for at least 3 months
  • Primary reviewer for at least 5 PRs to the codebase
  • Reviewed or merged at least 20 substantial PRs to the codebase

cc @parispittman

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 2, 2018
@robinpercy
Copy link
Contributor Author

/assign @chrislovecnm
/assign @justinsb

@mikesplain
Copy link
Contributor

Thanks @robinpercy!

@chrislovecnm
Copy link
Contributor

@justinsb lgtm. We need two approvers to do this technically. So ball is in your court.

@justinsb
Copy link
Member

justinsb commented Apr 3, 2018

/approve

/lgtm

Welcome @robinpercy & @mikesplain

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 3, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb, robinpercy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 3, 2018
@k8s-ci-robot k8s-ci-robot merged commit 36d0fe4 into kubernetes:master Apr 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants