Remove forcing disabled cgos Darwin #7914
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unsure if this is the right approach but wanted to get some others input. I often run into issues on macOS where I cannot run
kops validate cluster
due to failed DNS resolution. I am using OpenVPN Connect which does not edit/etc/resolv.conf
(which is not standard anymore in macOS anyways at least). By forcingcgos
to be disabled,kops validate cluster
uses thenet
packages default resolver that only uses thenameserver
listed in/etc/resolv.conf
. In this case, that is the DHCP DNS, which fails.To see the DNS difference, you can see the single
nameserver
listed in/etc/resolv.conf
and then other resolvers which are populated via my VPN client.The PR that added this functionality was from a few years ago, and it seems all tests still pass and it did resolve my issue. Curious on others thoughts here. Links below for more detail:
PR adding it: #3709
Kubernetes/kubernetes PR for building on darwin for darwin_ to use
cgos
: kubernetes/kubernetes#64219