Include secondary protocol flag always

[jacksontj]

This way if you have the value set in config (even as "") it'll get
passed down to allow you to override the default config

Related to #9006

More detailed explanation: #9006 (comment)

[k8s-ci-robot]

Hi @jacksontj. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jacksontj]

/assign @mikesplain

[robinpercy]

/ok-to-test

[robinpercy]

@jacksontj I think the issue reference in the commit message has caused this to be labeled do-not-merge. Can you please try amending the commit to to remove that reference?

[jacksontj]

@robinpercy that label was actually removed 4 days ago (I fixed that commit message when I saw the label). I removed it from the PR text as well -- but as of this writing the do-not-merge label is not on this PR

[olemarkus]

/lgtm

[jacksontj]

@olemarkus who should we ping to get this approved? (bot is complaining it doesn't have an approved label)

[olemarkus]

The approvers regularly go through things with the lgtm label. If that doesn't happen, I'd try Slack.

[rifelpet]

Thanks @jacksontj ! is there any documentation that needs updating for this?

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jacksontj, rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [rifelpet]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jacksontj]

I don't think we have docs for the gossip upgrade yet, so when we have those we'd add there. In reality we probably don't need to doc this as this just makes the config option actually do something (do what you'd expect).