-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't put bastions in the utility subnets #9124
Conversation
ab47e44
to
ec4fe1e
Compare
/retest |
/lgtm |
This seems reasonable to me. Should we add a release note that mentions the change in behavior for new clusters? /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johngmyers, rifelpet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I assessed it as being below the threshold for a relnote. Do others think this needs to be called out? |
Since this is only for new clusters, I don't think this is very important to call out. Those who manage many clusters hopefully use templating and will also not be affected by this. We should probably update https://kops.sigs.k8s.io/bastion/ too though. |
I'm fine with not having a release note. feel free to cancel the hold when you're ready. |
/hold cancel |
There's no reason to put bastions in utility subnets as their securitygroup only allows incoming traffic from the load balancer.