Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CNI 0.8.6 for Kubernetes 1.15+ #9256

Merged
merged 1 commit into from
Jun 3, 2020
Merged

Conversation

hakman
Copy link
Member

@hakman hakman commented Jun 3, 2020

Due to security advisory kubernetes/kubernetes#91507, k/k upgraded the CNI binaries to 0.8.6 for 1.16+. We still support 1.15, so we should do it for it also.
Refs:

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 3, 2020
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 3, 2020
@olemarkus
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 3, 2020
@rifelpet
Copy link
Member

rifelpet commented Jun 3, 2020

hm, so existing k8s 1.15-1.17 clusters will be upgraded from 0.7.5 to 0.8.6 when they upgrade to the version of Kops that includes this? Are there any concerns with that upgrade process?

@hakman
Copy link
Member Author

hakman commented Jun 3, 2020

@rifelpet The idea was to migrate as much as possible to 0.8.6, probably including Kops 1.16.
I see that k/k set it as the default for 1.16+ so probably will not hurt 1.15 either.

If we merge it, we can see how the weekly e2e are behaving with older versions also.

@rifelpet
Copy link
Member

rifelpet commented Jun 3, 2020

ok, yes we can merge this and keep an eye on the 1.15 job before we release the next kops version that includes this 👍

https://testgrid.k8s.io/kops-versions#kops-aws-k8s-1.15

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman, rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 3, 2020
@k8s-ci-robot k8s-ci-robot merged commit dbcf6f7 into kubernetes:master Jun 3, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Jun 3, 2020
k8s-ci-robot added a commit that referenced this pull request Jun 3, 2020
…pstream-release-1.18

Automated cherry pick of #9256: Use CNI 0.8.6 for Kubernetes 1.15+
@hakman hakman deleted the cni-0.8.6 branch June 3, 2020 17:05
@rifelpet rifelpet modified the milestones: v1.18, v1.19 Jun 4, 2020
k8s-ci-robot added a commit that referenced this pull request Jun 9, 2020
…pstream-release-1.17

Automated cherry pick of #9256: Use CNI 0.8.6 for Kubernetes 1.15+
k8s-ci-robot added a commit that referenced this pull request Jun 9, 2020
…pstream-release-1.16

Automated cherry pick of #9256: Use CNI 0.8.6 for Kubernetes 1.15+
oded7hoffman pushed a commit to spotinst/kubernetes-kops that referenced this pull request Jan 23, 2023
…of-#9256-upstream-release-1.16

Automated cherry pick of kubernetes#9256: Use CNI 0.8.6 for Kubernetes 1.15+
oded7hoffman pushed a commit to spotinst/kubernetes-kops that referenced this pull request Jan 23, 2023
…of-#9256-upstream-release-1.16

Automated cherry pick of kubernetes#9256: Use CNI 0.8.6 for Kubernetes 1.15+
oded7hoffman pushed a commit to spotinst/kubernetes-kops that referenced this pull request Jan 23, 2023
…of-#9256-upstream-release-1.16

Automated cherry pick of kubernetes#9256: Use CNI 0.8.6 for Kubernetes 1.15+
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants