Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow failure of the ARM64 job in TravisCI #9279

Merged
merged 1 commit into from
Jun 5, 2020
Merged

Allow failure of the ARM64 job in TravisCI #9279

merged 1 commit into from
Jun 5, 2020

Conversation

hakman
Copy link
Member

@hakman hakman commented Jun 5, 2020

The ARM64 test in TravisCI seems flaky and should be allowed to fail for now until we have a chance to see if anything can be improved.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 5, 2020
@rifelpet
Copy link
Member

rifelpet commented Jun 5, 2020

is there an example failure you can link to? just curious

@johngmyers
Copy link
Member

@rifelpet https://travis-ci.org/github/kubernetes/kops/builds/694863847

@johngmyers
Copy link
Member

/lgtm
(Though I don't think removing the OSX comment is necessary.)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 5, 2020
@hakman
Copy link
Member Author

hakman commented Jun 5, 2020

Also this: https://travis-ci.org/github/kubernetes/kops/builds/694878314
Had to restart this test multiple times this morning to get it to pass. May be just a problem with TravisCI infra, but not that important for not to block merging.

@rifelpet
Copy link
Member

rifelpet commented Jun 5, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman, rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 5, 2020
@k8s-ci-robot k8s-ci-robot merged commit 367177f into kubernetes:master Jun 5, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Jun 5, 2020
@hakman hakman deleted the travis-allow-failures branch June 5, 2020 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KashifSaadat KashifSaadat Awaiting requested review from KashifSaadat

@rdrgmnzs rdrgmnzs Awaiting requested review from rdrgmnzs

Assignees

@johngmyers johngmyers

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.
4 participants
@hakman @rifelpet @johngmyers @k8s-ci-robot