-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use filebase64 for launch template userdata and Terraform 0.12 #9532
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rifelpet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cc @fred-vogt |
@rifelpet: GitHub didn't allow me to request PR reviews from the following users: fred-vogt. Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@rifelpet - I can confirm this fixes the issue for me with a build of your branch. |
/lgtm |
In order to provide the HCL2 generation code with knowledge of which function to use for each file reference (
file()
vsfilebase64()
we need to store that in the Literal, so this adds a new field with that information.Fixes #9518