Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spotinst: Change ScaleDown.MaxPercentage from int to float64 #9683

Merged
merged 1 commit into from
Aug 5, 2020

Conversation

liranp
Copy link
Contributor

@liranp liranp commented Aug 4, 2020

This PR upgrades the Spot SDK and aligns the ScaleDown.MaxPercentage field with the Spot API spec.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 4, 2020
@k8s-ci-robot k8s-ci-robot added the area/provider/spotinst Issues or PRs related to spotinst provider label Aug 4, 2020
@liranp
Copy link
Contributor Author

liranp commented Aug 4, 2020

/retest

@hakman
Copy link
Member

hakman commented Aug 5, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 5, 2020
@hakman
Copy link
Member

hakman commented Aug 5, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman, liranp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 5, 2020
@k8s-ci-robot k8s-ci-robot merged commit d61ab29 into kubernetes:master Aug 5, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Aug 5, 2020
@liranp liranp deleted the fix-max-scale-down branch August 5, 2020 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/spotinst Issues or PRs related to spotinst provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants