Openstack golden servergrouptests #9874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
area/provider/openstack
|
/cc @johngmyers |
…ng for golden output
olemarkus
force-pushed
the
openstack-golden-servergrouptests
branch
from
b54a01b to
f5ac6d7
Compare
olemarkus
force-pushed
the
openstack-golden-servergrouptests
branch
from
f5ac6d7 to
54ccc92
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johngmyers, olemarkus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Openstack servergroup test had a rather intricate method for building tasks and diffing them. Instead of using that specific code, the test now just generates golden outputs based on the same spec, which makes the tests a whole lot more manageable, as well as easier to figure out what would cause failures.
I did some rudimentary bit flipping in
servergroup.goto see that this indeed causes test failures.