Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change breaks client-go: gnostic -> gnostic-models #404

Closed
regnaio opened this issue Jun 1, 2023 · 7 comments
Closed

Change breaks client-go: gnostic -> gnostic-models #404

regnaio opened this issue Jun 1, 2023 · 7 comments
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@regnaio
Copy link

regnaio commented Jun 1, 2023

Breaking change commit: 38767cd

Why the change from gnostic -> gnostic-models?


Updated packages using go get -u ./...

Then, I tried running a go file using go run <FILE>

Got the error message:

# k8s.io/client-go/applyconfigurations/meta/v1
/go/pkg/mod/k8s.io/client-go@v0.27.2/applyconfigurations/meta/v1/unstructured.go:64:38: cannot use doc (variable of type *"github.com/google/gnostic/openapiv2".Document) as *"github.com/google/gnostic-models/openapiv2".Document value in argument to proto.NewOpenAPIData

proto.NewOpenAPIData is part of k8s.io/kube-openapi/pkg/util/proto

Breaking change occurred somewhere between:
k8s.io/kube-openapi: v0.0.0-20230525220651-2546d827e515 (5/25/2023) ---> v0.0.0-20230531092745-9b4dcd38a4bf (5/31/2023)

https://pkg.go.dev/k8s.io/kube-openapi?tab=versions

@regnaio regnaio changed the title Breaking change from 5/25/2023 to 5/31/2023 Breaking change: gnostic -> gnostic-models Jun 1, 2023
@regnaio regnaio changed the title Breaking change: gnostic -> gnostic-models Change breaks client-go: gnostic -> gnostic-models Jun 3, 2023
@Tochemey
Copy link

Tochemey commented Jun 6, 2023

Any update on this issue

@Jefftree
Copy link
Member

Jefftree commented Jun 7, 2023

Hi, can I ask why you're running go get -u on client-go? Is there a use case for upgrading the dependencies without upgrading client go? We pin dependencies for a reason and v0.27.2 is pinned to a version of kube-openapi without the breaking change (https://github.com/kubernetes/client-go/blob/v0.27.2/go.mod)

If you'd like to upgrade client-go, HEAD contains the fixes kubernetes/client-go@2bd3f49 for it.

@imjasonh
Copy link

imjasonh commented Jun 8, 2023

Moving some conversations from the linked issue:

Is it expected that the https://github.com/google/gnostic-models repo has one commit, from more than a year ago?

@Jefftree

@imjasonh I just talked to the repo owner, the repo is synced from the gnostic repo so CI is run on gnostic instead.

However, is it still expected that the repo has received no updates since its first one over a year ago, including some fairly simple dep updates?

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 22, 2024
petr-muller added a commit to petr-muller/ota that referenced this issue Feb 9, 2024
I mistakenly cleared my Go cache and then I started seeing kubernetes/kube-openapi#404
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 21, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

@k8s-ci-robot
Copy link
Contributor

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 22, 2024
hrak added a commit to Leaseweb/cluster-api-provider-cloudstack that referenced this issue Jul 10, 2024
hrak added a commit to Leaseweb/cluster-api-provider-cloudstack that referenced this issue Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

6 participants