Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make proto validation errors public #17

Merged
merged 1 commit into from
Nov 1, 2017

Conversation

apelisse
Copy link
Member

@apelisse apelisse commented Nov 1, 2017

Error types should have been public ...

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 1, 2017
@mengqiy
Copy link
Member

mengqiy commented Nov 1, 2017

LGTM

@mbohlool mbohlool merged commit 39a7bf8 into kubernetes:master Nov 1, 2017
sttts pushed a commit to sttts/kube-openapi that referenced this pull request Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants