Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump all Go dependencies #489

Merged
merged 1 commit into from
Jul 26, 2024
Merged

Conversation

lucacome
Copy link
Contributor

@lucacome lucacome commented Jul 9, 2024

Bumps all the dependencies to the latest version available. Hopefully after this dependabot will start behaving...

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 9, 2024
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 9, 2024
@Jefftree
Copy link
Member

Looks like a type change in gengo: kubernetes/gengo@2a31dd7.

@lucacome
Copy link
Contributor Author

Reverting gengo so we can update it in a separate PR

Signed-off-by: Luca Comellini <luca.com@gmail.com>
@lucacome
Copy link
Contributor Author

@Jefftree can we merge this?

@Jefftree
Copy link
Member

hey, sorry been super busy with code freeze. Would you mind opening a k/k PR just to make sure tests are passing? I can also do it later this week.

@lucacome
Copy link
Contributor Author

Do you mean after these changes are merged?
If so I already have a PR up that I'm going to update kubernetes/kubernetes#124632

@Jefftree
Copy link
Member

Jefftree commented Jul 25, 2024

Before the changes are merged by creating a temp PR pinned to your kube-openapi update branch and verifying the tests have no problems

./hack/pin-dependency.sh k8s.io/kube-openapi=github.com/lucacome/kube-openapi bump-deps

https://github.com/kubernetes/kubernetes/blob/6a95d2048e3dbb51db0e10a50d021a2e77ce79a3/go.mod#L248

Created the test PR here: kubernetes/kubernetes#126362

@lucacome
Copy link
Contributor Author

oh I didn't know you could pin it like that, cool!

@Jefftree
Copy link
Member

tests look good!
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 26, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jefftree, lucacome

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 26, 2024
@k8s-ci-robot k8s-ci-robot merged commit 6f6746f into kubernetes:master Jul 26, 2024
4 checks passed
@lucacome lucacome deleted the bump-deps branch July 26, 2024 04:02
github.com/asaskevich/govalidator v0.0.0-20230301143203-a9d515a09cc2
github.com/emicklei/go-restful/v3 v3.12.1
github.com/go-openapi/jsonreference v0.21.0
github.com/go-openapi/swag v0.23.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

govalidator, go-restful, jsonreference need review before bumping, these impact kubernetes API surface and behavior

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants