Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tighten validation of inlining and metadata #504

Merged
merged 2 commits into from
Sep 3, 2024
Merged

tighten validation of inlining and metadata #504

merged 2 commits into from
Sep 3, 2024

Commits on Aug 26, 2024

  1. names match: add unit tests demonstrating false positives 

    Not checking empty JSON names and "metadata" has the effect that incorrect
usage of those does not get detected. These new unit tests demonstrate
that. Fixing the behavior and updating the tests accordingly will follow.
    @pohly
    pohly committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    4fca853 View commit details
    Browse the repository at this point in the history

  2. names match: tighten validation of inlining and metadata 

    Because "" and "metadata" were excluded from checking, some incorrect
usage of those were not detected.

Also, naming ListMeta or ObjectMeta "listMeta" or "objectMeta" was allowed
because the names match, even though by convention the name should have
been "metadata".
    @pohly
    pohly committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    5b13d40 View commit details
    Browse the repository at this point in the history