Properly initialize spec.Definitions when merging specs #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
size/L
|
/cc @mbohlool |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
k8s-github-robot
pushed a commit
to kubernetes/kubernetes
that referenced
this pull request
May 3, 2018
Automatic merge from submit-queue (batch tested with PRs 61455, 63346, 63130, 63404). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Bump kube-openapi dependency **What this PR does / why we need it**: Pick up kubernetes/kube-openapi#64 **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes #63218 **Special notes for your reviewer**: **Release note**: ```release-note NONE ``` /sig api-machinery /cc @mbohlool @liggitt
k8s-publishing-bot
added a commit
to kubernetes/code-generator
that referenced
this pull request
May 4, 2018
Automatic merge from submit-queue (batch tested with PRs 61455, 63346, 63130, 63404). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Bump kube-openapi dependency **What this PR does / why we need it**: Pick up kubernetes/kube-openapi#64 **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes #63218 **Special notes for your reviewer**: **Release note**: ```release-note NONE ``` /sig api-machinery /cc @mbohlool @liggitt Kubernetes-commit: 89e6895e1c550658b7c145436868b70fb3cabbcd
k8s-publishing-bot
added a commit
to kubernetes/apimachinery
that referenced
this pull request
May 4, 2018
Automatic merge from submit-queue (batch tested with PRs 61455, 63346, 63130, 63404). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Bump kube-openapi dependency **What this PR does / why we need it**: Pick up kubernetes/kube-openapi#64 **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes #63218 **Special notes for your reviewer**: **Release note**: ```release-note NONE ``` /sig api-machinery /cc @mbohlool @liggitt Kubernetes-commit: 89e6895e1c550658b7c145436868b70fb3cabbcd
k8s-publishing-bot
added a commit
to kubernetes/client-go
that referenced
this pull request
May 4, 2018
Automatic merge from submit-queue (batch tested with PRs 61455, 63346, 63130, 63404). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Bump kube-openapi dependency **What this PR does / why we need it**: Pick up kubernetes/kube-openapi#64 **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes #63218 **Special notes for your reviewer**: **Release note**: ```release-note NONE ``` /sig api-machinery /cc @mbohlool @liggitt Kubernetes-commit: 89e6895e1c550658b7c145436868b70fb3cabbcd
k8s-publishing-bot
added a commit
to kubernetes/apiserver
that referenced
this pull request
May 4, 2018
Automatic merge from submit-queue (batch tested with PRs 61455, 63346, 63130, 63404). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Bump kube-openapi dependency **What this PR does / why we need it**: Pick up kubernetes/kube-openapi#64 **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes #63218 **Special notes for your reviewer**: **Release note**: ```release-note NONE ``` /sig api-machinery /cc @mbohlool @liggitt Kubernetes-commit: 89e6895e1c550658b7c145436868b70fb3cabbcd
k8s-publishing-bot
added a commit
to kubernetes/kube-aggregator
that referenced
this pull request
May 4, 2018
Automatic merge from submit-queue (batch tested with PRs 61455, 63346, 63130, 63404). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Bump kube-openapi dependency **What this PR does / why we need it**: Pick up kubernetes/kube-openapi#64 **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes #63218 **Special notes for your reviewer**: **Release note**: ```release-note NONE ``` /sig api-machinery /cc @mbohlool @liggitt Kubernetes-commit: 89e6895e1c550658b7c145436868b70fb3cabbcd
k8s-publishing-bot
added a commit
to kubernetes/sample-apiserver
that referenced
this pull request
May 4, 2018
Automatic merge from submit-queue (batch tested with PRs 61455, 63346, 63130, 63404). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Bump kube-openapi dependency **What this PR does / why we need it**: Pick up kubernetes/kube-openapi#64 **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes #63218 **Special notes for your reviewer**: **Release note**: ```release-note NONE ``` /sig api-machinery /cc @mbohlool @liggitt Kubernetes-commit: 89e6895e1c550658b7c145436868b70fb3cabbcd
k8s-publishing-bot
added a commit
to kubernetes/sample-controller
that referenced
this pull request
May 4, 2018
Automatic merge from submit-queue (batch tested with PRs 61455, 63346, 63130, 63404). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Bump kube-openapi dependency **What this PR does / why we need it**: Pick up kubernetes/kube-openapi#64 **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes #63218 **Special notes for your reviewer**: **Release note**: ```release-note NONE ``` /sig api-machinery /cc @mbohlool @liggitt Kubernetes-commit: 89e6895e1c550658b7c145436868b70fb3cabbcd
k8s-publishing-bot
added a commit
to kubernetes/apiextensions-apiserver
that referenced
this pull request
May 4, 2018
Automatic merge from submit-queue (batch tested with PRs 61455, 63346, 63130, 63404). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Bump kube-openapi dependency **What this PR does / why we need it**: Pick up kubernetes/kube-openapi#64 **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes #63218 **Special notes for your reviewer**: **Release note**: ```release-note NONE ``` /sig api-machinery /cc @mbohlool @liggitt Kubernetes-commit: 89e6895e1c550658b7c145436868b70fb3cabbcd
This was referenced May 9, 2018
k8s-publishing-bot
added a commit
to kubernetes/sample-apiserver
that referenced
this pull request
May 10, 2018
Automatic merge from submit-queue. Manual cherrypick of kube-openapi changes for release-1.9 **What this PR does / why we need it**: Cherry-picks kubernetes/kube-openapi#64 and kubernetes/kube-openapi#67 Fixes bugs that make apiserver panic when aggregating valid but not well formed OpenAPI spec (with empty `Paths`/`Definitions`) **Release note**: ```release-note Fixes bugs that make apiserver panic when aggregating valid but not well formed OpenAPI spec ``` /cc @mbohlool /sig api-machinery Kubernetes-commit: 8d48604c2eca912159636be258a5e68bfc4c6643
k8s-publishing-bot
added a commit
to kubernetes/sample-controller
that referenced
this pull request
May 10, 2018
Automatic merge from submit-queue. Manual cherrypick of kube-openapi changes for release-1.9 **What this PR does / why we need it**: Cherry-picks kubernetes/kube-openapi#64 and kubernetes/kube-openapi#67 Fixes bugs that make apiserver panic when aggregating valid but not well formed OpenAPI spec (with empty `Paths`/`Definitions`) **Release note**: ```release-note Fixes bugs that make apiserver panic when aggregating valid but not well formed OpenAPI spec ``` /cc @mbohlool /sig api-machinery Kubernetes-commit: 8d48604c2eca912159636be258a5e68bfc4c6643
k8s-publishing-bot
added a commit
to kubernetes/apiextensions-apiserver
that referenced
this pull request
May 10, 2018
Automatic merge from submit-queue. Manual cherrypick of kube-openapi changes for release-1.9 **What this PR does / why we need it**: Cherry-picks kubernetes/kube-openapi#64 and kubernetes/kube-openapi#67 Fixes bugs that make apiserver panic when aggregating valid but not well formed OpenAPI spec (with empty `Paths`/`Definitions`) **Release note**: ```release-note Fixes bugs that make apiserver panic when aggregating valid but not well formed OpenAPI spec ``` /cc @mbohlool /sig api-machinery Kubernetes-commit: 8d48604c2eca912159636be258a5e68bfc4c6643
k8s-publishing-bot
added a commit
to kubernetes/metrics
that referenced
this pull request
May 10, 2018
Automatic merge from submit-queue. Manual cherrypick of kube-openapi changes for release-1.9 **What this PR does / why we need it**: Cherry-picks kubernetes/kube-openapi#64 and kubernetes/kube-openapi#67 Fixes bugs that make apiserver panic when aggregating valid but not well formed OpenAPI spec (with empty `Paths`/`Definitions`) **Release note**: ```release-note Fixes bugs that make apiserver panic when aggregating valid but not well formed OpenAPI spec ``` /cc @mbohlool /sig api-machinery Kubernetes-commit: 8d48604c2eca912159636be258a5e68bfc4c6643
k8s-github-robot
pushed a commit
to kubernetes/kubernetes
that referenced
this pull request
May 10, 2018
Automatic merge from submit-queue. Manual cherrypick of kube-openapi changes for release-1.8 **What this PR does / why we need it**: Cherry-picks kubernetes/kube-openapi#64 and kubernetes/kube-openapi#67 Fixes bugs that make apiserver panic when aggregating valid but not well formed OpenAPI spec (with empty `Paths`/`Definitions`) **Release note**: ```release-note Fixes bugs that make apiserver panic when aggregating valid but not well formed OpenAPI spec ``` /cc @jpbetz /sig api-machinery
k8s-publishing-bot
added a commit
to kubernetes/code-generator
that referenced
this pull request
May 10, 2018
Automatic merge from submit-queue. Manual cherrypick of kube-openapi changes for release-1.8 **What this PR does / why we need it**: Cherry-picks kubernetes/kube-openapi#64 and kubernetes/kube-openapi#67 Fixes bugs that make apiserver panic when aggregating valid but not well formed OpenAPI spec (with empty `Paths`/`Definitions`) **Release note**: ```release-note Fixes bugs that make apiserver panic when aggregating valid but not well formed OpenAPI spec ``` /cc @jpbetz /sig api-machinery Kubernetes-commit: 4ab16f7d4499fcb3b770b1260fa33855632c7e44
k8s-publishing-bot
added a commit
to kubernetes/apimachinery
that referenced
this pull request
May 10, 2018
Automatic merge from submit-queue. Manual cherrypick of kube-openapi changes for release-1.8 **What this PR does / why we need it**: Cherry-picks kubernetes/kube-openapi#64 and kubernetes/kube-openapi#67 Fixes bugs that make apiserver panic when aggregating valid but not well formed OpenAPI spec (with empty `Paths`/`Definitions`) **Release note**: ```release-note Fixes bugs that make apiserver panic when aggregating valid but not well formed OpenAPI spec ``` /cc @jpbetz /sig api-machinery Kubernetes-commit: 4ab16f7d4499fcb3b770b1260fa33855632c7e44
k8s-publishing-bot
added a commit
to kubernetes/api
that referenced
this pull request
May 10, 2018
Automatic merge from submit-queue. Manual cherrypick of kube-openapi changes for release-1.8 **What this PR does / why we need it**: Cherry-picks kubernetes/kube-openapi#64 and kubernetes/kube-openapi#67 Fixes bugs that make apiserver panic when aggregating valid but not well formed OpenAPI spec (with empty `Paths`/`Definitions`) **Release note**: ```release-note Fixes bugs that make apiserver panic when aggregating valid but not well formed OpenAPI spec ``` /cc @jpbetz /sig api-machinery Kubernetes-commit: 4ab16f7d4499fcb3b770b1260fa33855632c7e44
k8s-publishing-bot
added a commit
to kubernetes/client-go
that referenced
this pull request
May 10, 2018
Automatic merge from submit-queue. Manual cherrypick of kube-openapi changes for release-1.8 **What this PR does / why we need it**: Cherry-picks kubernetes/kube-openapi#64 and kubernetes/kube-openapi#67 Fixes bugs that make apiserver panic when aggregating valid but not well formed OpenAPI spec (with empty `Paths`/`Definitions`) **Release note**: ```release-note Fixes bugs that make apiserver panic when aggregating valid but not well formed OpenAPI spec ``` /cc @jpbetz /sig api-machinery Kubernetes-commit: 4ab16f7d4499fcb3b770b1260fa33855632c7e44
k8s-publishing-bot
added a commit
to kubernetes/apiserver
that referenced
this pull request
May 10, 2018
Automatic merge from submit-queue. Manual cherrypick of kube-openapi changes for release-1.8 **What this PR does / why we need it**: Cherry-picks kubernetes/kube-openapi#64 and kubernetes/kube-openapi#67 Fixes bugs that make apiserver panic when aggregating valid but not well formed OpenAPI spec (with empty `Paths`/`Definitions`) **Release note**: ```release-note Fixes bugs that make apiserver panic when aggregating valid but not well formed OpenAPI spec ``` /cc @jpbetz /sig api-machinery Kubernetes-commit: 4ab16f7d4499fcb3b770b1260fa33855632c7e44
k8s-publishing-bot
added a commit
to kubernetes/kube-aggregator
that referenced
this pull request
May 10, 2018
Automatic merge from submit-queue. Manual cherrypick of kube-openapi changes for release-1.8 **What this PR does / why we need it**: Cherry-picks kubernetes/kube-openapi#64 and kubernetes/kube-openapi#67 Fixes bugs that make apiserver panic when aggregating valid but not well formed OpenAPI spec (with empty `Paths`/`Definitions`) **Release note**: ```release-note Fixes bugs that make apiserver panic when aggregating valid but not well formed OpenAPI spec ``` /cc @jpbetz /sig api-machinery Kubernetes-commit: 4ab16f7d4499fcb3b770b1260fa33855632c7e44
k8s-publishing-bot
added a commit
to kubernetes/sample-apiserver
that referenced
this pull request
May 10, 2018
Automatic merge from submit-queue. Manual cherrypick of kube-openapi changes for release-1.8 **What this PR does / why we need it**: Cherry-picks kubernetes/kube-openapi#64 and kubernetes/kube-openapi#67 Fixes bugs that make apiserver panic when aggregating valid but not well formed OpenAPI spec (with empty `Paths`/`Definitions`) **Release note**: ```release-note Fixes bugs that make apiserver panic when aggregating valid but not well formed OpenAPI spec ``` /cc @jpbetz /sig api-machinery Kubernetes-commit: 4ab16f7d4499fcb3b770b1260fa33855632c7e44
k8s-publishing-bot
added a commit
to kubernetes/apiextensions-apiserver
that referenced
this pull request
May 10, 2018
Automatic merge from submit-queue. Manual cherrypick of kube-openapi changes for release-1.8 **What this PR does / why we need it**: Cherry-picks kubernetes/kube-openapi#64 and kubernetes/kube-openapi#67 Fixes bugs that make apiserver panic when aggregating valid but not well formed OpenAPI spec (with empty `Paths`/`Definitions`) **Release note**: ```release-note Fixes bugs that make apiserver panic when aggregating valid but not well formed OpenAPI spec ``` /cc @jpbetz /sig api-machinery Kubernetes-commit: 4ab16f7d4499fcb3b770b1260fa33855632c7e44
k8s-publishing-bot
added a commit
to kubernetes/metrics
that referenced
this pull request
May 10, 2018
Automatic merge from submit-queue. Manual cherrypick of kube-openapi changes for release-1.8 **What this PR does / why we need it**: Cherry-picks kubernetes/kube-openapi#64 and kubernetes/kube-openapi#67 Fixes bugs that make apiserver panic when aggregating valid but not well formed OpenAPI spec (with empty `Paths`/`Definitions`) **Release note**: ```release-note Fixes bugs that make apiserver panic when aggregating valid but not well formed OpenAPI spec ``` /cc @jpbetz /sig api-machinery Kubernetes-commit: 4ab16f7d4499fcb3b770b1260fa33855632c7e44
k8s-github-robot
pushed a commit
to kubernetes/kubernetes
that referenced
this pull request
May 15, 2018
Automatic merge from submit-queue. Manual cherrypick of kube-openapi changes for release-1.10 **What this PR does / why we need it**: Cherry-picks kubernetes/kube-openapi#64 and kubernetes/kube-openapi#67 Fixes bugs that make apiserver panic when aggregating valid but not well formed OpenAPI spec (with empty `Paths`/`Definitions`) **Release note**: ```release-note Fixes bugs that make apiserver panic when aggregating valid but not well formed OpenAPI spec ``` /cc @MaciekPytel /sig api-machinery
k8s-publishing-bot
added a commit
to kubernetes/code-generator
that referenced
this pull request
May 15, 2018
Automatic merge from submit-queue. Manual cherrypick of kube-openapi changes for release-1.10 **What this PR does / why we need it**: Cherry-picks kubernetes/kube-openapi#64 and kubernetes/kube-openapi#67 Fixes bugs that make apiserver panic when aggregating valid but not well formed OpenAPI spec (with empty `Paths`/`Definitions`) **Release note**: ```release-note Fixes bugs that make apiserver panic when aggregating valid but not well formed OpenAPI spec ``` /cc @MaciekPytel /sig api-machinery Kubernetes-commit: 42b63c8b19d1ad96399ec3f5a409da67e2fd19bd
k8s-publishing-bot
added a commit
to kubernetes/apimachinery
that referenced
this pull request
May 15, 2018
Automatic merge from submit-queue. Manual cherrypick of kube-openapi changes for release-1.10 **What this PR does / why we need it**: Cherry-picks kubernetes/kube-openapi#64 and kubernetes/kube-openapi#67 Fixes bugs that make apiserver panic when aggregating valid but not well formed OpenAPI spec (with empty `Paths`/`Definitions`) **Release note**: ```release-note Fixes bugs that make apiserver panic when aggregating valid but not well formed OpenAPI spec ``` /cc @MaciekPytel /sig api-machinery Kubernetes-commit: 42b63c8b19d1ad96399ec3f5a409da67e2fd19bd
k8s-publishing-bot
added a commit
to kubernetes/client-go
that referenced
this pull request
May 15, 2018
Automatic merge from submit-queue. Manual cherrypick of kube-openapi changes for release-1.10 **What this PR does / why we need it**: Cherry-picks kubernetes/kube-openapi#64 and kubernetes/kube-openapi#67 Fixes bugs that make apiserver panic when aggregating valid but not well formed OpenAPI spec (with empty `Paths`/`Definitions`) **Release note**: ```release-note Fixes bugs that make apiserver panic when aggregating valid but not well formed OpenAPI spec ``` /cc @MaciekPytel /sig api-machinery Kubernetes-commit: 42b63c8b19d1ad96399ec3f5a409da67e2fd19bd
k8s-publishing-bot
added a commit
to kubernetes/apiserver
that referenced
this pull request
May 15, 2018
Automatic merge from submit-queue. Manual cherrypick of kube-openapi changes for release-1.10 **What this PR does / why we need it**: Cherry-picks kubernetes/kube-openapi#64 and kubernetes/kube-openapi#67 Fixes bugs that make apiserver panic when aggregating valid but not well formed OpenAPI spec (with empty `Paths`/`Definitions`) **Release note**: ```release-note Fixes bugs that make apiserver panic when aggregating valid but not well formed OpenAPI spec ``` /cc @MaciekPytel /sig api-machinery Kubernetes-commit: 42b63c8b19d1ad96399ec3f5a409da67e2fd19bd
k8s-publishing-bot
added a commit
to kubernetes/kube-aggregator
that referenced
this pull request
May 15, 2018
Automatic merge from submit-queue. Manual cherrypick of kube-openapi changes for release-1.10 **What this PR does / why we need it**: Cherry-picks kubernetes/kube-openapi#64 and kubernetes/kube-openapi#67 Fixes bugs that make apiserver panic when aggregating valid but not well formed OpenAPI spec (with empty `Paths`/`Definitions`) **Release note**: ```release-note Fixes bugs that make apiserver panic when aggregating valid but not well formed OpenAPI spec ``` /cc @MaciekPytel /sig api-machinery Kubernetes-commit: 42b63c8b19d1ad96399ec3f5a409da67e2fd19bd
k8s-publishing-bot
added a commit
to kubernetes/sample-apiserver
that referenced
this pull request
May 15, 2018
Automatic merge from submit-queue. Manual cherrypick of kube-openapi changes for release-1.10 **What this PR does / why we need it**: Cherry-picks kubernetes/kube-openapi#64 and kubernetes/kube-openapi#67 Fixes bugs that make apiserver panic when aggregating valid but not well formed OpenAPI spec (with empty `Paths`/`Definitions`) **Release note**: ```release-note Fixes bugs that make apiserver panic when aggregating valid but not well formed OpenAPI spec ``` /cc @MaciekPytel /sig api-machinery Kubernetes-commit: 42b63c8b19d1ad96399ec3f5a409da67e2fd19bd
k8s-publishing-bot
added a commit
to kubernetes/sample-controller
that referenced
this pull request
May 15, 2018
Automatic merge from submit-queue. Manual cherrypick of kube-openapi changes for release-1.10 **What this PR does / why we need it**: Cherry-picks kubernetes/kube-openapi#64 and kubernetes/kube-openapi#67 Fixes bugs that make apiserver panic when aggregating valid but not well formed OpenAPI spec (with empty `Paths`/`Definitions`) **Release note**: ```release-note Fixes bugs that make apiserver panic when aggregating valid but not well formed OpenAPI spec ``` /cc @MaciekPytel /sig api-machinery Kubernetes-commit: 42b63c8b19d1ad96399ec3f5a409da67e2fd19bd
k8s-publishing-bot
added a commit
to kubernetes/apiextensions-apiserver
that referenced
this pull request
May 15, 2018
Automatic merge from submit-queue. Manual cherrypick of kube-openapi changes for release-1.10 **What this PR does / why we need it**: Cherry-picks kubernetes/kube-openapi#64 and kubernetes/kube-openapi#67 Fixes bugs that make apiserver panic when aggregating valid but not well formed OpenAPI spec (with empty `Paths`/`Definitions`) **Release note**: ```release-note Fixes bugs that make apiserver panic when aggregating valid but not well formed OpenAPI spec ``` /cc @MaciekPytel /sig api-machinery Kubernetes-commit: 42b63c8b19d1ad96399ec3f5a409da67e2fd19bd
openshift-publish-robot
pushed a commit
to openshift/kubernetes-sample-controller
that referenced
this pull request
Jan 14, 2019
Automatic merge from submit-queue (batch tested with PRs 61455, 63346, 63130, 63404). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Bump kube-openapi dependency **What this PR does / why we need it**: Pick up kubernetes/kube-openapi#64 **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes #63218 **Special notes for your reviewer**: **Release note**: ```release-note NONE ``` /sig api-machinery /cc @mbohlool @liggitt Kubernetes-commit: 89e6895e1c550658b7c145436868b70fb3cabbcd
openshift-publish-robot
pushed a commit
to openshift/kubernetes-sample-apiserver
that referenced
this pull request
Jan 14, 2019
Automatic merge from submit-queue (batch tested with PRs 61455, 63346, 63130, 63404). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Bump kube-openapi dependency **What this PR does / why we need it**: Pick up kubernetes/kube-openapi#64 **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes #63218 **Special notes for your reviewer**: **Release note**: ```release-note NONE ``` /sig api-machinery /cc @mbohlool @liggitt Kubernetes-commit: 89e6895e1c550658b7c145436868b70fb3cabbcd
sttts
pushed a commit
to sttts/kube-openapi
that referenced
this pull request
Nov 5, 2020
Fix TestSchemaValidator_Panic
tamalsaha
pushed a commit
to gomodules/encoding
that referenced
this pull request
Aug 10, 2021
Automatic merge from submit-queue (batch tested with PRs 61455, 63346, 63130, 63404). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Bump kube-openapi dependency **What this PR does / why we need it**: Pick up kubernetes/kube-openapi#64 **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes #63218 **Special notes for your reviewer**: **Release note**: ```release-note NONE ``` /sig api-machinery /cc @mbohlool @liggitt Kubernetes-commit: 89e6895e1c550658b7c145436868b70fb3cabbcd
akhilerm
pushed a commit
to akhilerm/apimachinery
that referenced
this pull request
Sep 20, 2022
Automatic merge from submit-queue (batch tested with PRs 61455, 63346, 63130, 63404). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Bump kube-openapi dependency **What this PR does / why we need it**: Pick up kubernetes/kube-openapi#64 **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes #63218 **Special notes for your reviewer**: **Release note**: ```release-note NONE ``` /sig api-machinery /cc @mbohlool @liggitt Kubernetes-commit: 89e6895e1c550658b7c145436868b70fb3cabbcd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes kubernetes/kubernetes#63218
When aggregating openapi specs, depending on sort priority, a valid openapi spec with empty
Definitionsmay become the first specToReturn. Currently the aggregator panics on "assignment to entry in nil map". This PR initialize the map if it's nil.