-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add StatefulSet Start Ordinal metrics for KEP-3335 #1959
Add StatefulSet Start Ordinal metrics for KEP-3335 #1959
Conversation
2cb8e64
to
b8d86b2
Compare
b8d86b2
to
4a3510d
Compare
QQ: how to set alerts around metric kube_statefulset_ordinals_start? Does it compare with actual pod deletion/creation order? |
This metric is used to inform a cluster administrator about usage, rather than correctness of the feature.
kube_statefulset_ordinals_start reports the specified .spec.ordinals.start field, if .spec.ordinals is set. This enables a cluster administrator to monitor the usage of this feature. I considered adding a metric that indicated the status of the start ordinal, but in the KEP review, it was decided this wasn't super valuable to measure. See kubernetes/enhancements#3768 (comment) for context. |
/cc @soltysh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/triage accepted |
2b8e8ec
to
56d6c68
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dgrisonnet, pwschuurman, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Add metrics for new StatefulSet fields from KEP-3335
How does this change affect the cardinality of KSM: (increases, decreases or does not change cardinality)
Does not change the cardinality of KSM