Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add StatefulSet Start Ordinal metrics for KEP-3335 #1959

Merged
merged 3 commits into from
Mar 13, 2023

Conversation

pwschuurman
Copy link
Contributor

@pwschuurman pwschuurman commented Jan 23, 2023

What this PR does / why we need it:
Add metrics for new StatefulSet fields from KEP-3335

How does this change affect the cardinality of KSM: (increases, decreases or does not change cardinality)
Does not change the cardinality of KSM

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 23, 2023
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 23, 2023
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 23, 2023
@pwschuurman pwschuurman marked this pull request as ready for review February 24, 2023 00:29
@pwschuurman pwschuurman changed the title [WIP] Add StatefulSet Start Ordinal metrics for KEP-3335 Add StatefulSet Start Ordinal metrics for KEP-3335 Feb 24, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 24, 2023
@CatherineF-dev
Copy link
Contributor

QQ: how to set alerts around metric kube_statefulset_ordinals_start?

Does it compare with actual pod deletion/creation order?

@pwschuurman
Copy link
Contributor Author

QQ: how to set alerts around metric kube_statefulset_ordinals_start?

This metric is used to inform a cluster administrator about usage, rather than correctness of the feature.

Does it compare with actual pod deletion/creation order?

kube_statefulset_ordinals_start reports the specified .spec.ordinals.start field, if .spec.ordinals is set. This enables a cluster administrator to monitor the usage of this feature. I considered adding a metric that indicated the status of the start ordinal, but in the KEP review, it was decided this wasn't super valuable to measure. See kubernetes/enhancements#3768 (comment) for context.

@pwschuurman
Copy link
Contributor Author

/cc @soltysh

Copy link

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 3, 2023
internal/store/statefulset_test.go Outdated Show resolved Hide resolved
internal/store/statefulset.go Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 8, 2023
@dgrisonnet
Copy link
Member

/triage accepted
/assign @logicalhan

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 9, 2023
Copy link
Member

@dgrisonnet dgrisonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 13, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgrisonnet, pwschuurman, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 13, 2023
@k8s-ci-robot k8s-ci-robot merged commit 1202714 into kubernetes:main Mar 13, 2023
@rexagod rexagod mentioned this pull request May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants