-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add volumemode to PVC info metric #2134
feat: add volumemode to PVC info metric #2134
Conversation
Signed-off-by: João Vilaça <jvilaca@redhat.com>
/assign @dgrisonnet |
/lgtm |
Can you update https://github.com/kubernetes/kube-state-metrics/blob/main/docs/persistentvolumeclaim-metrics.md to include the new attribute as well? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new metric look reasonable to me. My approval is pending Manuel's comment resolution: #2134 (comment)
Signed-off-by: João Vilaça <jvilaca@redhat.com>
@mrueg updated |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CatherineF-dev, machadovilaca, mrueg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
This PR adds a label to
kube_persistentvolumeclaim_info
to track the volume mode set in the PVC, either "Block" or "Filesystem"How does this change affect the cardinality of KSM: (increases, decreases or does not change cardinality)
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #