Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove usage of the k8s-master label (version marker) #2237

Closed
neolit123 opened this issue Jul 29, 2020 · 5 comments · Fixed by kubernetes/kubernetes#93626
Closed

remove usage of the k8s-master label (version marker) #2237

neolit123 opened this issue Jul 29, 2020 · 5 comments · Fixed by kubernetes/kubernetes#93626
Assignees
@vikkyomkar
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/backlog Higher priority than priority/awaiting-more-evidence.
Milestone
v1.20

Comments

@neolit123
Copy link
Member

remove k8s-master from here and the unit tests:
https://github.com/kubernetes/kubernetes/blob/master/cmd/kubeadm/app/util/version_test.go#L199
https://github.com/kubernetes/kubernetes/blob/master/cmd/kubeadm/app/util/version_test.go#L239

xref kubernetes/test-infra#18517
@neolit123 neolit123 added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jul 29, 2020
@neolit123
Copy link
Member Author

/help
/good-first-issue

note we are are in code-freeze for 1.19, but your change can merge in late august for 1.20.

@k8s-ci-robot
Copy link
Contributor

@neolit123:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/help
/good-first-issue

note we are are in code-freeze for 1.19, but your change can merge in late august for 1.20.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Jul 29, 2020
@neolit123
Copy link
Member Author

/milestone v1.20

@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Jul 29, 2020
@neolit123 neolit123 added the priority/backlog Higher priority than priority/awaiting-more-evidence. label Jul 29, 2020
@vikkyomkar
Copy link

/assign

@neolit123
Copy link
Member Author

also this line: https://github.com/kubernetes/kubernetes/blob/master/cmd/kubeadm/app/util/version.go#L64

@vikkyomkar vikkyomkar mentioned this issue Aug 1, 2020
Merged
@neolit123 neolit123 added lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. and removed good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vikkyomkar vikkyomkar

Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Milestone
v1.20
Development

Successfully merging a pull request may close this issue.

[Cleanup] Removes usage of the k8s-master label (version marker) vikkyomkar/kubernetes
3 participants
@neolit123 @k8s-ci-robot @vikkyomkar