Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove ClusterStatus from v1beta3 #2290

Closed
2 tasks done
neolit123 opened this issue Sep 16, 2020 · 6 comments
Closed
2 tasks done

remove ClusterStatus from v1beta3 #2290

neolit123 opened this issue Sep 16, 2020 · 6 comments
Assignees
@neolit123
Labels
kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.

Comments

@neolit123
Copy link
Member

neolit123 commented Sep 16, 2020 •
edited
Loading

following this KEP:
https://github.com/kubernetes/enhancements/tree/master/keps/sig-cluster-lifecycle/kubeadm/2506-Remove-ClusterStatus-from-kubeadm-config

this PR deprecated ClusterStatus in 1.18:
kubernetes/kubernetes#87656

the structure is part of v1beta{1|2}. we are not going to remove it from the older v1betaX APIs, but we can remove it from v1beta3:
#1796

PRs:
@neolit123
Copy link
Member Author

neolit123 commented Sep 16, 2020 •
edited
Loading

skew and upgrades need discussion:

  • kubeadm upgrade needs to perform cleanup of the config map to remove ClusterStatus
  • what happens if we try to deploy a cluster using v1beta2 with a version of kubeadm that no longer handles ClusterStatus?
  • should we remove ClusterStatus handling from kubeadm only after the last API version that supports it is removed (i.e. v1beta2)?

@neolit123 neolit123 added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. labels Sep 16, 2020
@neolit123 neolit123 added this to the Next milestone Sep 16, 2020
@neolit123 neolit123 added the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Sep 16, 2020
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 15, 2020
@neolit123
Copy link
Member Author

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 15, 2020
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 15, 2021
@fabriziopandini
Copy link
Member

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 15, 2021
@neolit123 neolit123 modified the milestones: Next, v1.22 Apr 14, 2021
@neolit123 neolit123 mentioned this issue Apr 14, 2021
Closed
16 tasks
@neolit123 neolit123 mentioned this issue May 11, 2021
Merged
@neolit123 neolit123 self-assigned this May 11, 2021
@neolit123
Copy link
Member Author

close as the main work was completed.
one remaining item is tracked here:
#2480

@neolit123 neolit123 mentioned this issue Oct 25, 2021
Merged
@neolit123 neolit123 mentioned this issue Jan 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@neolit123 neolit123

Labels
kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@neolit123 @fabriziopandini @k8s-ci-robot @fejta-bot