Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubeadm: retroactively update old KEPs #3150

Merged
merged 1 commit into from
Jan 19, 2022

Conversation

neolit123
Copy link
Member

@neolit123 neolit123 commented Jan 17, 2022

The work on some of the these enhancements completed a long
time ago. Perform the following cleanup:

  • 2500, 2502 (HA features) have been in beta for ~7 releases
    and can be considered GA without much changes other than bug fixes.
    Separate tracking is already done for future improvements
    that may need separate KEPs (e.g. learner mode for etcd). Promote them to GA and close.
  • 2051 was about moving the kubeadm phases to beta. "upgrade apply"
    still does not have phases, so a separate KEP might be required TBD. Promote the old KEP as Beta / implemented.
  • 2506 the work completed in 1.22, when ClusterStatus was removed
    from v1beta3. Promote to GA.

clusterstatus: kubernetes/kubeadm#2290
phases for "apply": kubernetes/kubeadm#1318

ha issues:
learner mode: kubernetes/kubeadm#1793
closes kubernetes/kubeadm#2081
closes #357
closes #2500
closes #2502

The work on some of the these enhancements completed a long
time ago.

- 2500, 2502 (HA features) have been in beta for ~7 releases
and can be considered GA without much changes other than bug fixes.
Separate tracking is already done for future improvements
that may need separate KEPs (e.g. learner mode for etcd).
- 2051 was about moving the kubeadm phases to beta. "upgrade apply"
still does not have phases, so a separate KEP might be required TBD.
- 2506 the work completed in 1.22, when ClusterStatus was removed
from v1beta3
@neolit123 neolit123 added sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Jan 17, 2022
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 17, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: neolit123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from justinsb January 17, 2022 11:14
@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 17, 2022
@fabriziopandini
Copy link
Member

That's a nice cleanup
/lgtm
/hold
for giving other folks some time to chime in

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 17, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 17, 2022
Copy link
Member

@SataQiu SataQiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@neolit123
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 19, 2022
@k8s-ci-robot k8s-ci-robot merged commit 787515f into kubernetes:master Jan 19, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
4 participants