kinder: call "upgrade plan" before "upgrade apply" #2973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
neolit123
added
priority/backlog
neolit123
force-pushed
the
1.29-add-upgrade-plan-to-kinder
branch
from
cefa0de to
48f9038
Compare
|
/hold EDIT: done |
k8s-ci-robot
added
the
do-not-merge/hold
neolit123
force-pushed
the
1.29-add-upgrade-plan-to-kinder
branch
from
48f9038 to
fbd1644
Compare
|
looking for LGTM on this one so we can merge when 1.30 starts. |
k8s-ci-robot
added
the
lgtm
chendave
reviewed
Dec 6, 2023
kinder/ci/tools/update-workflows/templates/workflows/dryrun-tasks.yaml
Outdated
Show resolved
Hide resolved
During the kinder "kubeadm-upgrade" action, "upgrade apply" is executed, but "upgrade plan" is not. To ensure better coverage ensure "upgrade plan" is called as well. We have this command as part of the kubeadm upgrade docs, so it makes sense to have it here. Ensure that "plan" is also called during the "upgrade-latest-no-addon-config-maps" workflow.
neolit123
force-pushed
the
1.29-add-upgrade-plan-to-kinder
branch
from
fbd1644 to
a560645
Compare
k8s-ci-robot
removed
the
lgtm
|
1.30 is out i'm going to unhold my kinder PRs one at a time to make sure we don't break many things at once. |
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chendave, neolit123, SataQiu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the kinder "kubeadm-upgrade" action, "upgrade apply"
is executed, but "upgrade plan" is not. To ensure better coverage
ensure "upgrade plan" is called as well. We have this command
as part of the kubeadm upgrade docs, so it makes sense to have
it here.
Ensure that "plan" is also called during the
"upgrade-latest-no-addon-config-maps" workflow.
NOTE: untested locally, but the presubmit job here should catch problems. i think this is all that has to be done.
fixes #2971