Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable CoreDNS by default in v1.11 #782

Closed
timothysc opened this issue May 1, 2018 · 7 comments
Closed

Enable CoreDNS by default in v1.11 #782

timothysc opened this issue May 1, 2018 · 7 comments
Assignees
@neolit123 @detiber
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/network Categorizes an issue or PR as relevant to SIG Network.
Milestone
v1.11

Comments

@timothysc
Copy link
Member

Both IPVS, and CoreDNS are being moved to beta and we should determine if we are ready to enable and default.

I'd be in favor of enabling CoreDNS as a default, but I'm slightly concerned about the ordering IPVS and who should do what.

/cc @kubernetes/sig-cluster-lifecycle-misc @kubernetes/sig-network-misc

/assign @detiber
@k8s-ci-robot k8s-ci-robot added sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/network Categorizes an issue or PR as relevant to SIG Network. labels May 1, 2018
@timothysc timothysc self-assigned this May 1, 2018
@timothysc timothysc added the kind/feature Categorizes issue or PR as related to a new feature. label May 1, 2018
@timothysc timothysc added this to the v1.11 milestone May 1, 2018
@timothysc timothysc added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label May 1, 2018
@luxas
Copy link
Member

luxas commented May 2, 2018

I think enabling CoreDNS by default in v1.11 makes sense. kubeadm is beta, which requires our dependencies to be beta. I don't expect our clusters to break when making this the default, but we might even catch one or two bugs in CoreDNS by exposing more users to it before it goes GA.

What we win on doing this is better reliability and higher performance by default.

@bowei
Copy link
Member

bowei commented May 3, 2018 •
edited
Loading

BTW - CoreDNS is going GA but we are not enabling CoreDNS by default in 1.11 in the main repo.

@bowei
Copy link
Member

bowei commented May 3, 2018

Upon closer reading -- is "enabling" the same as making the default?

@detiber
Copy link
Member

detiber commented May 3, 2018

@bowei the discussion here is to consider making CoreDNS the default for kubeadm-based installs. it is already available as a featureGate on kubeadm installs.

@detiber detiber mentioned this issue May 7, 2018
Merged
@timothysc timothysc removed their assignment May 11, 2018
@luxas luxas changed the title RFE: Networking Beta Feature Enablement and defaults Enable CoreDNS by default in v1.11 May 15, 2018
@luxas luxas mentioned this issue May 15, 2018
Closed
@luxas
Copy link
Member

luxas commented May 15, 2018

Split this into two tickets, this one for CoreDNS in v1.11 and #817 for ipvs in the future

@detiber detiber added the lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. label May 15, 2018
k8s-github-robot pushed a commit to kubernetes/kubernetes that referenced this issue May 15, 2018
Merge pull request #63509 from detiber/CoreDNSDefault
67200c9 
Automatic merge from submit-queue (batch tested with PRs 63658, 63509, 63800, 63586, 63840). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

kubeadm - default CoreDNS FeatureGate to true

**What this PR does / why we need it**:

This PR updates kubeadm to deploy CoreDNS rather than KubeDNS by default for new installs.

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Addresses part of kubernetes/kubeadm#782

**Release note**:
```release-note
kubeadm will now deploy CoreDNS by default instead of KubeDNS
```

Currently, this does not effect upgrades. Also, documentation updates will need to be coordinated with this change.
@neolit123
Copy link
Member

/assign

for the docs.

@luxas
Copy link
Member

luxas commented May 22, 2018

kubernetes/kubernetes#63509 fixed this. Please open a new issue for documenting this @neolit123

@luxas luxas closed this as completed May 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@neolit123 neolit123

@detiber detiber

Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/network Categorizes an issue or PR as relevant to SIG Network.
Projects
None yet
Milestone
v1.11
Development

No branches or pull requests
6 participants
@timothysc @neolit123 @bowei @detiber @luxas @k8s-ci-robot