-
Notifications
You must be signed in to change notification settings - Fork 712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set the kubelet --hostname-override
flag conditionally at kubeadm init time
#846
Comments
There is another tricky little aspect to this. Since we currently deploy kube-proxy as a daemonset with a single config map, we also need to have a way to pass this value along to the kube-proxy config as well, otherwise Services of type |
@detiber do you have more information on this somewhere? Would this mean every kube-proxy daemon needs to be configured differently? |
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. kubeadm: Let the `--node-name` flag flow down to `--hostname-override` for the kubelet **What this PR does / why we need it**: Kubeadm-initialised kubelet uses provided hostname if present If --node-name is passed in to `kubeadm init`, `--hostname-override` will be passed to kubelet. This prevents timeout errors for `kubeadm init`. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes kubernetes/kubeadm#846 **Special notes for your reviewer**: Depends on #64624 to work fully, but can safely merged before hand. **Release note**: ```release-note [action required] The `--node-name` flag for kubeadm now dictates the Node API object name the kubelet uses for registration, in all cases but where you might use an in-tree cloud provider. If you're not using an in-tree cloud provider, `--node-name` will set the Node API object name. If you're using an in-tree cloud provider, you MUST make `--node-name` match the name the in-tree cloud provider decides to use. ```
When kubernetes/kubernetes#63887 merges, we should set the kubelet's
--hostname-override
flag to what's passed to kubeadm via the--node-name
flag conditionallyif cfg.NodeName != nodeutil.GetHostname("")
(if the flag differs from the default) at kubeadm init time, incmd/kubeadm/app/phases/kubelet/flags.go
.This will automagically fix #584
xref related issue: #822
/assign @liztio
as you're assigned to #584. LMK if you don't have time to do this.
The text was updated successfully, but these errors were encountered: