kinder: pin the CR cgroup driver to "systemd" #2495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neolit123
added
priority/critical-urgent
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
|
after merging kubernetes/kubernetes#99647 and without this the CI would / can fail. EDIT: i tested both the docker and containerd images locally. |
neolit123
force-pushed
the
1.22-pin-cgroup-driver-in-kinder
branch
from
5e39195
to
165aaae
Compare
|
/retest |
Pin the driver to "systemd" in: - the Docker / containerd config files during image alter - KubeletConfiguration that kubeadm deploys
neolit123
force-pushed
the
1.22-pin-cgroup-driver-in-kinder
branch
from
165aaae
to
920dc0e
Compare
neolit123
commented
May 31, 2021
Comment on lines
+50
to
+62
| // Workaround from https://github.com/kubernetes/kubernetes/issues/43704#issuecomment-289484654 | ||
| // Using the systemd driver in our rather old base image results in errors around the kubepods.slice. | ||
| // Write the flags --cgroups-per-qos=false --enforce-node-allocatable="" in the KUBELET_EXTRA_ARGS file. | ||
| // | ||
| // It's not possible to pass these via the KubeletConfiguration because the validation / defaulting is bogus. | ||
| // Empty slice gets defaulted to "pods" and non-empty slice fails for 'cgroupsPerQOS: false' - | ||
| // i.e. it is not possible to pass 'none' or '[]' for the 'enforceNodeAllocatable' config field. | ||
| // https://github.com/kubernetes/kubernetes/blob/ea0764452222146c47ec826977f49d7001b0ea8c/pkg/kubelet/apis/config/validation/validation.go#L53-L54 | ||
| if err := bc.RunInContainer("bash", "-c", | ||
| "printf 'KUBELET_EXTRA_ARGS=\"--cgroups-per-qos=false --enforce-node-allocatable=\"\"\"' > /etc/default/kubelet", | ||
| ); err != nil { | ||
| return errors.Wrap(err, "could not write /etc/default/kubelet") | ||
| } |
There was a problem hiding this comment.
debugging this was a lot of "fun".
This was referenced May 31, 2021
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini, neolit123 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pin the driver to "systemd" in:
xref #874