kinder: add handling of the new/old kubelet-config map #2654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With UnversionedKubeletConfigMap going Beta in 1.24 and enabled by default, we want to match what kubeadm is doing: - look of the new name of CM - if that fails fallback to the old CM name leave a TODO to remove this extra handling once 1.24 goes out of support. This would mean that all tested versions of kubeadm only have UnversionedKubeletConfigMap=true and the new CM name.
neolit123
added
priority/important-soon
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
sig/cluster-lifecycle
12 tasks
pacoxu
reviewed
Feb 10, 2022
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: neolit123, pacoxu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
let's merge this to let it run in CI. |
k8s-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With UnversionedKubeletConfigMap going Beta in 1.24
and enabled by default, we want to match what kubeadm is doing:
leave a TODO to remove this extra handling once 1.24
goes out of support. This would mean that all tested
versions of kubeadm only have UnversionedKubeletConfigMap=true
and the new CM name.
xref #1582
xref kubernetes/kubernetes#108027
(does not depend strictly on the this PR)
NOTE: i'm not touching the only e2e test workflow for this because it already excercises the case for upgrading from a state with old names -> new names.
https://github.com/kubernetes/kubeadm/blob/main/kinder/ci/workflows/unversioned-kubelet-cm-tasks.yaml#L113-L125
we can technically add a new workflow with the FG turned off and tested during init, but i don't think that is necessary.