Merge pull request #125802 from mmorel-35/testifylint/len+empty

fix: enable empty and len rules from testifylint on pkg and staging package Kubernetes-commit: 2d4514e1690dc5babb144542da799f6b331afd1b
kubernetes · Jul 12, 2024 · 5867261 · 5867261
2 parents 15aefcb + 1a58d7f
commit 5867261
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 14 deletions.
diff --git a/go.mod b/go.mod
@@ -29,11 +29,11 @@ require (
  golang.org/x/sys v0.21.0
  gopkg.in/evanphx/json-patch.v4 v4.12.0
  gopkg.in/yaml.v2 v2.4.0
- k8s.io/api v0.0.0-20240707022826-2cf4612580d3
- k8s.io/apimachinery v0.0.0-20240711022542-6b362fab6df2
+ k8s.io/api v0.0.0-20240712023323-4badb3333d55
+ k8s.io/apimachinery v0.0.0-20240711222537-4524748494bf
  k8s.io/cli-runtime v0.0.0-20240711160938-80033e7bae90
- k8s.io/client-go v0.0.0-20240710183246-7f36d816ee99
- k8s.io/component-base v0.0.0-20240707024307-c741ec442cc3
+ k8s.io/client-go v0.0.0-20240712063246-53b8be7ceab5
+ k8s.io/component-base v0.0.0-20240712064316-a485d5310861
  k8s.io/component-helpers v0.0.0-20240707024433-5a2d7426dbcc
  k8s.io/klog/v2 v2.130.1
  k8s.io/kube-openapi v0.0.0-20240228011516-70dd3763d340

diff --git a/go.sum b/go.sum
@@ -277,16 +277,16 @@ gopkg.in/yaml.v3 v3.0.1 h1:fxVm/GzAzEWqLHuvctI91KS9hhNmmWOoWu0XTYJS7CA=
 gopkg.in/yaml.v3 v3.0.1/go.mod h1:K4uyk7z7BCEPqu6E+C64Yfv1cQ7kz7rIZviUmN+EgEM=
 honnef.co/go/tools v0.0.0-20190102054323-c2f93a96b099/go.mod h1:rf3lG4BRIbNafJWhAfAdb/ePZxsR/4RtNHQocxwk9r4=
 honnef.co/go/tools v0.0.0-20190523083050-ea95bdfd59fc/go.mod h1:rf3lG4BRIbNafJWhAfAdb/ePZxsR/4RtNHQocxwk9r4=
-k8s.io/api v0.0.0-20240707022826-2cf4612580d3 h1:2bHi5SAn7dRf6oJGO29yFEtMyIN9oCD86In1R70UnXA=
-k8s.io/api v0.0.0-20240707022826-2cf4612580d3/go.mod h1:TeZW9JsLR2mmT3LA7JsD/4i5g40HHrREIdaD0QCEP1Y=
-k8s.io/apimachinery v0.0.0-20240711022542-6b362fab6df2 h1:NFXoAJM3jIlKAOfDNCKb29pjw8iNnhtT+Z6YOQhXM50=
-k8s.io/apimachinery v0.0.0-20240711022542-6b362fab6df2/go.mod h1:Et4EUFrefx1K28ZwNXpkHUqq7fSML2FROj79Ku7Lj1w=
+k8s.io/api v0.0.0-20240712023323-4badb3333d55 h1:n44Qr23IUW2bPIMGrDScIdqmu1u+XUHqdd0O0hTj2pM=
+k8s.io/api v0.0.0-20240712023323-4badb3333d55/go.mod h1:O8LAmMgsWzumSE9wGhqSdC+9HFxJ3Bh+NuDzms9R/D4=
+k8s.io/apimachinery v0.0.0-20240711222537-4524748494bf h1:BO1LyfoftoDsAxaqL9zPspuFZPuY2mq8vH4qqqoAodc=
+k8s.io/apimachinery v0.0.0-20240711222537-4524748494bf/go.mod h1:Et4EUFrefx1K28ZwNXpkHUqq7fSML2FROj79Ku7Lj1w=
 k8s.io/cli-runtime v0.0.0-20240711160938-80033e7bae90 h1:VE4DMc3nU/Y945k78wqxjPY+hGdDSEWHuzhfpy0FhXQ=
 k8s.io/cli-runtime v0.0.0-20240711160938-80033e7bae90/go.mod h1:yAmTKyXms0bDV26vzKNx2mlvEJV0rylfuXJDbR8LQ8w=
-k8s.io/client-go v0.0.0-20240710183246-7f36d816ee99 h1:ay9vtgW1GcBryEkZPnfx6pmWmkmLTWLKn3TizDGeTqI=
-k8s.io/client-go v0.0.0-20240710183246-7f36d816ee99/go.mod h1:M4YkUERkMjSHhNDDe6dYdACCOtPD4td6mRAME6AX7i8=
-k8s.io/component-base v0.0.0-20240707024307-c741ec442cc3 h1:ipvnLvus3w+bw+jX1TQGeMyet9Gi/RBFgZ4g6dipaXM=
-k8s.io/component-base v0.0.0-20240707024307-c741ec442cc3/go.mod h1:VeVS94EfiiihI+wS+FbnUdsR6PcwWIL9dteXdwq0Jpw=
+k8s.io/client-go v0.0.0-20240712063246-53b8be7ceab5 h1:FlYnjobR2ssh20GtO47ze/jqACrODJjmPFPIuE8lj90=
+k8s.io/client-go v0.0.0-20240712063246-53b8be7ceab5/go.mod h1:t2i0B87/e6Kk2nUK0ctt34B/wr3K4unmBKrCKccHQuk=
+k8s.io/component-base v0.0.0-20240712064316-a485d5310861 h1:AwmiBQrQxXR2LIJvAJUgcXjTO4+4VwgzV11W9eRRzTI=
+k8s.io/component-base v0.0.0-20240712064316-a485d5310861/go.mod h1:ZxuU4mab/XnSM1RVJlvSGHQcByYTX3USY8snfOMOQog=
 k8s.io/component-helpers v0.0.0-20240707024433-5a2d7426dbcc h1:kB8GqtqhywwlqrqA2pbQgCSPqmlPO7/356BdVwUgpTQ=
 k8s.io/component-helpers v0.0.0-20240707024433-5a2d7426dbcc/go.mod h1:b2SbL4SfrOz9ftcrIXkJ+nqrdyzRIgpYi0N7Py6DViw=
 k8s.io/klog/v2 v2.130.1 h1:n9Xl7H1Xvksem4KFG4PYbdQCQxqc/tTUyrgXaOhHSzk=

diff --git a/pkg/cmd/apply/apply_test.go b/pkg/cmd/apply/apply_test.go
@@ -3432,7 +3432,7 @@ func TestApplySetDryRun(t *testing.T) {
  cmd.Run(cmd, []string{})
  })
  assert.Equal(t, "replicationcontroller/test-rc serverside-applied (server dry run)\n", outbuff.String())
- assert.Equal(t, len(serverSideData), 1, "unexpected creation")
+ assert.Len(t, serverSideData, 1, "unexpected creation")
  require.Nil(t, serverSideData[pathSecret], "secret was created")
  })
 
@@ -3449,7 +3449,7 @@ func TestApplySetDryRun(t *testing.T) {
  cmd.Run(cmd, []string{})
  })
  assert.Equal(t, "replicationcontroller/test-rc configured (dry run)\n", outbuff.String())
- assert.Equal(t, len(serverSideData), 1, "unexpected creation")
+ assert.Len(t, serverSideData, 1, "unexpected creation")
  require.Nil(t, serverSideData[pathSecret], "secret was created")
  })
 }