-
Notifications
You must be signed in to change notification settings - Fork 931
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new interactive flag into delete command #1330
Comments
/triaged accepted |
/assign |
Hey @ardaguclu I was thinking about taking this up. Can you please give me a user experience once this tag with delete would be present. For example
|
@MayukhSobo thanks for your interest on this issue. However, I have already started implementation. I'll let you know, if I need some help in the future.
I think, yes, we should especially ask when
Delete is disruptive command and basically, at least for now, we need it for only delete
We could not enable this interactivity by default because it breaks all CI jobs and current users. As a new flag, this will be the foundational work for kuberc and users will be able to set this flag as default in their kuberc file. |
I'm closing this issue, since we are going to track this via kubernetes/enhancements#3895 KEP /close |
@ardaguclu: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What would you like to be added:
Add a new interactive flag into delete command to ask user to proceed or not(something like
--interactive
,-i
,--confirm
?).Why is this needed:
As already known delete command should be used carefully because it is disruptive command. However, we could not have added interactivity("do you want to proceed or not") as default into delete, since it is a breaking change. In addition to that,
up to that time, there is no big difference between:
kubectl delete --all
andkubectl delete --all -i
. Because user types it, already confirms it.However, after the kuberc will be ready for use, users will be able to set default flags for built-in commands. To allow users set their default
delete
with interactivity. We need a flag to support that.The text was updated successfully, but these errors were encountered: