Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new interactive flag into delete command #1330

Closed
ardaguclu opened this issue Nov 21, 2022 · 6 comments · Fixed by kubernetes/kubernetes#114530
Closed

Add new interactive flag into delete command #1330

ardaguclu opened this issue Nov 21, 2022 · 6 comments · Fixed by kubernetes/kubernetes#114530
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@ardaguclu
Copy link
Member

What would you like to be added:
Add a new interactive flag into delete command to ask user to proceed or not(something like --interactive, -i, --confirm?).

Why is this needed:
As already known delete command should be used carefully because it is disruptive command. However, we could not have added interactivity("do you want to proceed or not") as default into delete, since it is a breaking change. In addition to that,
up to that time, there is no big difference between: kubectl delete --all and kubectl delete --all -i. Because user types it, already confirms it.

However, after the kuberc will be ready for use, users will be able to set default flags for built-in commands. To allow users set their default delete with interactivity. We need a flag to support that.

@ardaguclu ardaguclu added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 21, 2022
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Nov 21, 2022
@eddiezane
Copy link
Member

/triaged accepted
/priority backlog

ref eddiezane/kubernetes@e970248

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/backlog Higher priority than priority/awaiting-more-evidence. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Dec 7, 2022
@ardaguclu
Copy link
Member Author

/assign

@MayukhSobo
Copy link

Hey @ardaguclu I was thinking about taking this up. Can you please give me a user experience once this tag with delete would be present. For example

  1. Do we still ask the user for confirmation for all the resource when --all is used with --interactive?
  2. Do we only support it with delete as of now?
  3. This seems pretty straightforward. Why this is not there yet?

@ardaguclu
Copy link
Member Author

@MayukhSobo thanks for your interest on this issue.

However, I have already started implementation. I'll let you know, if I need some help in the future.

  1. Do we still ask the user for confirmation for all the resource when --all is used with --interactive?

I think, yes, we should especially ask when --all is passed.

  1. Do we only support it with delete as of now?

Delete is disruptive command and basically, at least for now, we need it for only delete

  1. This seems pretty straightforward. Why this is not there yet?

We could not enable this interactivity by default because it breaks all CI jobs and current users. As a new flag, this will be the foundational work for kuberc and users will be able to set this flag as default in their kuberc file.

@ardaguclu
Copy link
Member Author

I'm closing this issue, since we are going to track this via kubernetes/enhancements#3895 KEP

/close

@k8s-ci-robot
Copy link
Contributor

@ardaguclu: Closing this issue.

In response to this:

I'm closing this issue, since we are going to track this via kubernetes/enhancements#3895 KEP

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants