Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update min golang version to 1.18.1 #109484

Merged
merged 1 commit into from
Apr 14, 2022
Merged

Update min golang version to 1.18.1 #109484

merged 1 commit into from
Apr 14, 2022

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Apr 14, 2022

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Sets the min version to go1.18.1

Which issue(s) this PR fixes:

xref kubernetes/release#2499

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

/milestone v1.24

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 14, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Apr 14, 2022
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 14, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 14, 2022
@k8s-ci-robot k8s-ci-robot requested review from hwdef and sttts April 14, 2022 13:55
@liggitt
Copy link
Member Author

liggitt commented Apr 14, 2022

/cc @dims

@k8s-ci-robot k8s-ci-robot requested a review from dims April 14, 2022 14:15
@dims
Copy link
Member

dims commented Apr 14, 2022

/sig testing
/milestone v1.24
/priority critical-urgent
/triage accepted

Looks like macos 1.18.1 got resolved ( golang/go#52317 ) so we should be good.

@k8s-ci-robot k8s-ci-robot added sig/testing Categorizes an issue or PR as relevant to SIG Testing. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Apr 14, 2022
@dims
Copy link
Member

dims commented Apr 14, 2022

cc @kubernetes/release-team-leads @kubernetes/release-managers

@ameukam
Copy link
Member

ameukam commented Apr 14, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 14, 2022
@dims
Copy link
Member

dims commented Apr 14, 2022

/retest

@k8s-ci-robot k8s-ci-robot merged commit 10dcc6c into kubernetes:master Apr 14, 2022
@github-actions github-actions bot mentioned this pull request Apr 19, 2022
Open
@twz123 twz123 mentioned this pull request Apr 28, 2022
Merged
16 tasks
@liggitt liggitt deleted the go-min-version branch May 5, 2022 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hwdef hwdef Awaiting requested review from hwdef

@sttts sttts Awaiting requested review from sttts

@dims dims Awaiting requested review from dims

Assignees

@ameukam ameukam

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-none Denotes a PR that doesn't merit a release note. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.
4 participants
@liggitt @k8s-ci-robot @dims @ameukam