-
Notifications
You must be signed in to change notification settings - Fork 40k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable new set of Go metrics in Kubernetes #111910
Conversation
Please note that we're already in Test Freeze for the Fast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Thu Aug 18 07:40:11 UTC 2022. |
/cc @liggitt |
43b50a9
to
db239ee
Compare
/assign @logicalhan |
staging/src/k8s.io/component-base/metrics/legacyregistry/registry.go
Outdated
Show resolved
Hide resolved
For anyone looking into what this new Go package brings compare to the previous one, I would recommand having a look at prometheus/client_golang#955, it is well describe in this PR. |
db239ee
to
ce65b71
Compare
/retest |
Looks good to me, leaving approval to @logicalhan since he also wanted to have a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are the diff in the metrics? If there is a large delta (i.e. metrics are removed) this could break consumers.
This implementation adds all these metrics on top of the already exposed one: https://github.com/prometheus/client_golang/blob/main/prometheus/collectors/go_collector_latest_test.go#L92-L120. No metrics are removed, only new ones are added. |
We should add these to the release note. |
Done. Let me know if the release notes format in the PR's description suits you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt, logicalhan, tosi3k The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
This change adds more Golang-related metrics to Kubernetes which are useful when debugging Golang-related problems in Kubernetes.
Which issue(s) this PR fixes:
No issue is opened for that.
Special notes for your reviewer:
Bases on prometheus/client_golang version bump in #112052 which has to be submitted first.
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: